Fix Download folder location #610
Conversation
Get other default folders locations same way
ghost
added
the
|
@tsvietOK Excellent work! I didn't know UserDataPaths existed |
* Fix new folder/file creation looses focus with each letter (#607) * Fix Download folder location (#610) Get other default folders locations same way * Don't create folder or file if dialog was canceled (#608) * Add Invert Selection, icons to status bar, fix folder navigation and remove space before .dll (#604) * Remove space before .dll * Add Invert Selection, fix folder navigation crash Also fixes critical bug where a folder is deleted if it's moved into itself and the user presses skip * Add multiligual resources for new string * Various fixes for v0.7.6 (#611) * Prevent crash on opening new tab from folder * Prevent opening multiple new tabs from blocking the UI * Remove TabView Transition Animations * Fix Item Thumbnails not Loading * Ensure file type property is loaded Co-authored-by: Vladyslav <tsvetkov_vlad@ukr.net> Co-authored-by: Jeff Sieu <jeffsy00@gmail.com>
|
This change actually doesn't do anything, we actually read this data from the registry and this issue has already been fixed. I think this pull request should be reverted. |
|
@yaichenbaum I don't think we necessarily need to revert this because it does improve the detection of the downloads folder path. Before, we simply appended @"\Downloads" to the root user data folder path. If it is still a problem after this PR, we can work on improving the registry detection, but for now it looks like a decent improvement. (Unless there are other objections) |
|
@yaichenbaum I think you are not right. As i understand, this part with registry detection in Files.Launcher don't even running, try to debug Program.cs. |
|
@tsvietOK If that is the case we have some room for improvements in this area, if your change fixes the issue, then we should be able to remove the code from Files.Launcher. |
|
@yaichenbaum it's smth strange, it is workig even if i change this vars to random symbols
|
|
I think we need to move the startup task to the UWP project, we are changing the value of the settings there but the setting view model isn't updated. |
Get other default folders locations same way
Fixes #384