Skip to content

Add support for Tablet Mode's back button #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 24, 2020
Merged

Add support for Tablet Mode's back button #822

merged 14 commits into from
May 24, 2020

Conversation

jaigak
Copy link
Contributor

@jaigak jaigak commented May 21, 2020

Adds support for using Tablet Mode's back button for navigating between directories.

@yaira2 yaira2 self-requested a review May 21, 2020 11:57
@ghost ghost added the needs - code review label May 21, 2020
@yaira2
Copy link
Member

yaira2 commented May 22, 2020

@Jaiganeshkumaran Can you share a screenshot of how it will look with these changes?

@jaigak
Copy link
Contributor Author

jaigak commented May 22, 2020

@Jaiganeshkumaran Can you share a screenshot of how it will look with these changes?

There is no change in the UI. Only difference is that now the app responds to the tablet mode back button and uses it for navigating to the previous directory instead of switching to the previous app or the Start Screen.

@yaira2 yaira2 requested a review from lukeblevins May 22, 2020 04:05
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lukeblevins lukeblevins added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels May 24, 2020
@lukeblevins
Copy link
Contributor

@yaichenbaum This PR only adds support for the Windows 10 tablet mode back button. It won't affect the UI at all.

@yaira2 yaira2 merged commit fe9d674 into files-community:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants