Fix Jupyter plugin resize behavior #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Voila moved to JupyterLab proper as a front end instead of something hand rolled, so it will likely have better compatibility now (once we upgrade to JupyterLab 4) https://github.com/voila-dashboards/voila/releases/tag/v0.5.0 |
timkpaine
reviewed
Aug 30, 2023
| @@ -311,6 +311,7 @@ def run_check(self): | |||
| "Programming Language :: Python :: 3.9", | |||
| "Programming Language :: Python :: 3.10", | |||
| "Programming Language :: Python :: 3.11", | |||
| "Framework :: Jupyter :: JupyterLab :: Extensions :: Prebuilt", | |||
There was a problem hiding this comment.
Here are 2 others you might consider adding, though discoverability via this mechanism is not terribly popular https://github.com/timkpaine/ipydagred3/blob/0d8f858b84b7f65d9de5aa5ae59e54a502e3b5b2/pyproject.toml#L30
There was a problem hiding this comment.
There was a problem hiding this comment.
Yep that's where I got mine from
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
perspective-python's Jupyter plugin resize behavior to be vertical-only in notebook/cell mode, and non-resizable in other modes. Previous versions of Perspective allowed this plugin to be resized in both dimension, but this resizability overrides responsiveness to the notebook (or browser) dimension changes, leading to awkward user interactions when one wants to change the width of the notebook after using Perspective.This PR may break Voila, as per the note in the CSS I removed. Instead, I made this removed behavior "default" and made
<perspective-viewer>within a Notebook the selector forheight, which should work? But we have no tests nor convenient way to verify this. Additionally, I maintain the Voila fix was not correct - if we're going to distinguish behavior that is specific to Voila, it can't share classnames with Jupyter.