Why is the client context not used in verifyIDToken?

[xeoncross]

For some reason the ctx that is passed in is not used, instead a new blank context is created for no purpose.

firebase-admin-go/snippets/auth.go

Lines 80 to 82 in 79d5dcd

	func verifyIDToken(ctx context.Context, app *firebase.App, idToken string) *auth.Token {
	// [START verify_id_token_golang]
	client, err := app.Auth(context.Background())

[google-oss-bot]

This issue does not seem to follow the issue template. Make sure you provide all the required information.

[hiranya911]

No particular reason.

One could argue that since only the code between the [START] and [END] tags are actually rendered in the website, using context.Background() results in a clearer example. But I see ctx variable being used almost everywhere in these snippets, so it's probably safer (and better) to do the same here.

[xeoncross]

Using the provided ctx would allow the requester to cancel if needed. context.Background() will never cancel and severs the link between the caller.

[hiranya911]

You're welcome to provide a PR to update the snippet. But I don't think it's too critical, since we don't render the verifyToken() signature in the HTML output: https://firebase.google.com/docs/auth/admin/verify-id-tokens#verify_id_tokens_using_the_firebase_admin_sdk

[hiranya911]

@lahirumaramba this is a trivial change. Might be a good place for you to start.