Skip to content

Conversation

hiranya911
Copy link
Contributor

Description

Code sample

Copy link

@jwngr jwngr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwngr jwngr assigned hiranya911 and unassigned jwngr Apr 12, 2017
@hiranya911 hiranya911 merged commit 2c57a85 into master Apr 12, 2017
@hiranya911 hiranya911 deleted the hkj-release-421 branch April 12, 2017 20:18
TrCaM added a commit that referenced this pull request May 28, 2019
…ent class (#12)

* Added AppMetadata type

* Declare setDisplayName and listAppMetadata (unimplemented)
TrCaM added a commit that referenced this pull request May 30, 2019
…anagement (#541)

* Added AppMetadata type

* Declare setDisplayName and listAppMetadata (unimplemented)

* Declare listAppMetadata and setDisplayName methods in Project Management class (#12)

* Added AppMetadata type

* Declare setDisplayName and listAppMetadata (unimplemented)

* Update AndroidAppMetadata and IosAppMetadata

* Change AppMetadata to interface and displayName to be optional

* Rename file to app-metadata.ts and small fixes

* Move projectId and resourceName to AppMetadata

* Update index.d.ts
TrCaM added a commit that referenced this pull request Jun 4, 2019
… class (#546)

* Added AppMetadata type

* Declare setDisplayName and listAppMetadata (unimplemented)

* Declare listAppMetadata and setDisplayName methods in Project Management class (#12)

* Added AppMetadata type

* Declare setDisplayName and listAppMetadata (unimplemented)

* Update AndroidAppMetadata and IosAppMetadata

* Change AppMetadata to interface and displayName to be optional

* listAppMetadata: implement api request

* listAppMetadata: implement listAppMetadata in ProjectManagement class (#16)

* listAppMetadata: implement listAppMetadata in ProjectManagement class

* Clean up code to address comments

* Fix: non ios/android apps should be listed as PLATFORM_UNKNOWN (#18)

* Add integration test for ProjectManagement.listAppMetadata() (#17)

* Add integration test

* Fix listAppMetadata integration test

* Implement setDisplayName() for ProjectManagement class (#19)

* Implement setDisplayName() for ProjectManagement class

* fix integration test to address comment

* Enable promise support for integration test

* Fix listAppMetadata to match the update on AppMetatdata interface

* Handle nullable displayName and enum string mapping issues

* Update test for null display name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants