-
Notifications
You must be signed in to change notification settings - Fork 409
Implement listAppMetadata() and setDisplayName() of ProjectManagement class #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TrCaM
merged 15 commits into
tc-projectScopedOperations
from
tc-projectScopedOperations-cont
Jun 4, 2019
Merged
Implement listAppMetadata() and setDisplayName() of ProjectManagement class #546
TrCaM
merged 15 commits into
tc-projectScopedOperations
from
tc-projectScopedOperations-cont
Jun 4, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent class (#12) * Added AppMetadata type * Declare setDisplayName and listAppMetadata (unimplemented)
…te/firebase-admin-node into tc-projectScopedOperations-list
…#16) * listAppMetadata: implement listAppMetadata in ProjectManagement class * Clean up code to address comments
* Add integration test * Fix listAppMetadata integration test
* Implement setDisplayName() for ProjectManagement class * fix integration test to address comment * Enable promise support for integration test
TrCaM
commented
May 31, 2019
nbegley
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one last small request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend project scoped operations in the NodeJS Admin SDK with the addition of
AppMetadata
interface and 2 new methods intoProjectManagement
class (unimplemented):listAppMetadata()
: Lists summary of all apps belongs to the projectsetDisplayName()
: Update display name of the projectIn this pull request
listAppMetadata()
andsetDisplayName()
in ProjectManagement class and their Api requests