Fix a bunch of warnings on this class so that bryan can continue to have vimean superpowers. #5413

jrothfeder · 2023-10-12T21:07:08Z

No description provided.

github-actions · 2023-10-12T21:07:24Z

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

bryanatkinson

Haha, thanks :)

google-oss-bot · 2023-10-12T21:14:22Z

Coverage Report ¹

Affected Products

`firebase-sessions`

Overall coverage changed from 75.04% (15c3197) to 59.95% (6da1784) by -15.09%.

Filename	Base (`15c3197`)	Merge (`6da1784`)	Diff
Comparisons.kt	?	0.00%	?
Emitters.kt	?	0.00%	?
FirebaseSessionsRegistrar.kt	76.00%	76.19%	+0.19%
SafeCollector.common.kt	?	0.00%	?
SessionDatastore.kt	?	0.00%	?
SessionFirelogPublisher.kt	?	66.67%	?
SessionLifecycleClient.kt	?	0.00%	?
SessionLifecycleService.kt	?	0.00%	?
SessionMaintainer.kt	?	0.00%	?

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/MBX7rOwhLK.html

github-actions · 2023-10-12T21:16:42Z

Unit Test Results

    83 files +  21     83 suites +21 2m 38s ⏱️ - 4m 38s
1 044 tests +571 1 043 ✔️ +570 0 💤 ±0 1 ❌ +1
1 113 runs +161 1 112 ✔️ +160 0 💤 ±0 1 ❌ +1

For more details on these failures, see this check.

Results for commit 6d09ed6. ± Comparison against base commit 15c3197.

This pull request removes 473 and adds 1044 tests. Note that renamed tests count towards both.

com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testBindsService_oAndTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_OTargetingO_highPriority
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_fallsBackToBindService
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[19]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
…

com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…

google-oss-bot · 2023-10-12T21:29:05Z

Size Report ¹

Affected Products

firebase-sessions
Type Base (15c3197) Merge (6da1784) Diff
aar 108 kB 140 kB +32.3 kB (+29.9%)
apk (aggressive) 365 kB 366 kB +960 B (+0.3%)
apk (release) 2.07 MB 2.08 MB +10.4 kB (+0.5%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/k9yOm1VQS6.html

google-oss-bot · 2023-10-12T21:54:10Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (15c3197) and the CI merge commit (6da1784)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 15c3197: https://storage.googleapis.com/firebase-sdk-metric-reports/zKVLtpWbwX/index.html
- 6da1784: https://storage.googleapis.com/firebase-sdk-metric-reports/F1v0MHRy03/index.html

Startup Times

`fire-cls`

Device Statistics Distributions

oriole-32

Percentile	`15c3197`	`6da1784`	Diff	Significant (?)
p10	17.4 ±6 ms	13.1 ±6 ms	-4.27 ms (-24.5%)	NO
p25	18.6 ±6 ms	14.1 ±6 ms	-4.50 ms (-24.2%)	NO
p50	20.0 ±6 ms	15.6 ±7 ms	-4.46 ms (-22.2%)	NO
p75	21.7 ±6 ms	17.6 ±8 ms	-4.10 ms (-18.9%)	NO
p90	23.5 ±7 ms	19.7 ±8 ms	-3.82 ms (-16.2%)	NO

20 test runs in comparison

Commit	Test Runs
`15c3197`	2023-10-12_20:00:58.341116_envM 2023-10-12_20:00:58.344468_FIwZ 2023-10-12_20:00:58.344483_xSun 2023-10-12_20:00:58.344491_aLZt 2023-10-12_20:00:58.344497_uIdG 2023-10-12_20:00:58.344508_Ubra 2023-10-12_20:00:58.344515_nRAr 2023-10-12_20:00:58.344521_bsGK 2023-10-12_20:00:58.344528_TQfk 2023-10-12_20:00:58.344534_wQeT
`6da1784`	2023-10-12_21:25:31.940159_eKOL 2023-10-12_21:25:31.944055_MCVM 2023-10-12_21:25:31.944068_VZXQ 2023-10-12_21:25:31.944075_ckiv 2023-10-12_21:25:31.944081_hJlx 2023-10-12_21:25:31.944086_yCru 2023-10-12_21:25:31.944092_Lsdk 2023-10-12_21:25:31.944097_zOnU 2023-10-12_21:25:31.944103_cqgF 2023-10-12_21:25:31.944108_TgsQ

redfin-30

Percentile	`15c3197`	`6da1784`	Diff	Significant (?)
p10	22.6 ±10 ms	21.0 ±9.7 ms	-1.55 ms (-6.9%)	NO
p25	23.8 ±11 ms	22.4 ±11 ms	-1.39 ms (-5.9%)	NO
p50	25.6 ±12 ms	24.6 ±12 ms	-989 μs (-3.9%)	NO
p75	28.3 ±13 ms	27.6 ±14 ms	-677 μs (-2.4%)	NO
p90	31.9 ±14 ms	30.4 ±15 ms	-1.53 ms (-4.8%)	NO

20 test runs in comparison

Commit	Test Runs
`15c3197`	2023-10-12_20:00:58.341116_envM 2023-10-12_20:00:58.344468_FIwZ 2023-10-12_20:00:58.344483_xSun 2023-10-12_20:00:58.344491_aLZt 2023-10-12_20:00:58.344497_uIdG 2023-10-12_20:00:58.344508_Ubra 2023-10-12_20:00:58.344515_nRAr 2023-10-12_20:00:58.344521_bsGK 2023-10-12_20:00:58.344528_TQfk 2023-10-12_20:00:58.344534_wQeT
`6da1784`	2023-10-12_21:25:31.940159_eKOL 2023-10-12_21:25:31.944055_MCVM 2023-10-12_21:25:31.944068_VZXQ 2023-10-12_21:25:31.944075_ckiv 2023-10-12_21:25:31.944081_hJlx 2023-10-12_21:25:31.944086_yCru 2023-10-12_21:25:31.944092_Lsdk 2023-10-12_21:25:31.944097_zOnU 2023-10-12_21:25:31.944103_cqgF 2023-10-12_21:25:31.944108_TgsQ

`fire-perf`

Device Statistics Distributions

oriole-32

Percentile	`15c3197`	`6da1784`	Diff	Significant (?)
p10	267 ±19 μs	254 ±21 μs	-13.2 μs (-4.9%)	NO
p25	282 ±19 μs	264 ±19 μs	-17.3 μs (-6.1%)	NO
p50	302 ±20 μs	283 ±20 μs	-19.0 μs (-6.3%)	NO
p75	338 ±23 μs	316 ±19 μs	-21.9 μs (-6.5%)	NO
p90	393 ±43 μs	371 ±24 μs	-22.0 μs (-5.6%)	NO

20 test runs in comparison

Commit	Test Runs
`15c3197`	2023-10-12_20:00:58.341116_envM 2023-10-12_20:00:58.344468_FIwZ 2023-10-12_20:00:58.344483_xSun 2023-10-12_20:00:58.344491_aLZt 2023-10-12_20:00:58.344497_uIdG 2023-10-12_20:00:58.344508_Ubra 2023-10-12_20:00:58.344515_nRAr 2023-10-12_20:00:58.344521_bsGK 2023-10-12_20:00:58.344528_TQfk 2023-10-12_20:00:58.344534_wQeT
`6da1784`	2023-10-12_21:25:31.940159_eKOL 2023-10-12_21:25:31.944055_MCVM 2023-10-12_21:25:31.944068_VZXQ 2023-10-12_21:25:31.944075_ckiv 2023-10-12_21:25:31.944081_hJlx 2023-10-12_21:25:31.944086_yCru 2023-10-12_21:25:31.944092_Lsdk 2023-10-12_21:25:31.944097_zOnU 2023-10-12_21:25:31.944103_cqgF 2023-10-12_21:25:31.944108_TgsQ

redfin-30

Percentile	`15c3197`	`6da1784`	Diff	Significant (?)
p10	724 ±90 μs	703 ±83 μs	-20.5 μs (-2.8%)	NO
p25	757 ±84 μs	748 ±80 μs	-8.77 μs (-1.2%)	NO
p50	817 ±77 μs	814 ±72 μs	-2.74 μs (-0.3%)	NO
p75	897 ±82 μs	936 ±105 μs	+39.0 μs (+4.4%)	NO
p90	1.05 ±0.09 ms	1.07 ±0.1 ms	+26.7 μs (+2.5%)	NO

20 test runs in comparison

Commit	Test Runs
`15c3197`	2023-10-12_20:00:58.341116_envM 2023-10-12_20:00:58.344468_FIwZ 2023-10-12_20:00:58.344483_xSun 2023-10-12_20:00:58.344491_aLZt 2023-10-12_20:00:58.344497_uIdG 2023-10-12_20:00:58.344508_Ubra 2023-10-12_20:00:58.344515_nRAr 2023-10-12_20:00:58.344521_bsGK 2023-10-12_20:00:58.344528_TQfk 2023-10-12_20:00:58.344534_wQeT
`6da1784`	2023-10-12_21:25:31.940159_eKOL 2023-10-12_21:25:31.944055_MCVM 2023-10-12_21:25:31.944068_VZXQ 2023-10-12_21:25:31.944075_ckiv 2023-10-12_21:25:31.944081_hJlx 2023-10-12_21:25:31.944086_yCru 2023-10-12_21:25:31.944092_Lsdk 2023-10-12_21:25:31.944097_zOnU 2023-10-12_21:25:31.944103_cqgF 2023-10-12_21:25:31.944108_TgsQ

`fire-sessions`

Device Statistics Distributions

oriole-32

Percentile	`15c3197`	`6da1784`	Diff	Significant (?)
p10	8.06 ±1 ms	9.43 ±1 ms	+1.37 ms (+17.0%)	NO
p25	8.57 ±1 ms	9.93 ±1 ms	+1.36 ms (+15.9%)	NO
p50	9.25 ±1 ms	10.8 ±1 ms	+1.58 ms (+17.0%)	NO
p75	10.2 ±1 ms	12.2 ±2 ms	+2.06 ms (+20.3%)	NO
p90	11.3 ±1 ms	14.1 ±3 ms	+2.74 ms (+24.2%)	NO

20 test runs in comparison

Commit	Test Runs
`15c3197`	2023-10-12_20:00:58.341116_envM 2023-10-12_20:00:58.344468_FIwZ 2023-10-12_20:00:58.344483_xSun 2023-10-12_20:00:58.344491_aLZt 2023-10-12_20:00:58.344497_uIdG 2023-10-12_20:00:58.344508_Ubra 2023-10-12_20:00:58.344515_nRAr 2023-10-12_20:00:58.344521_bsGK 2023-10-12_20:00:58.344528_TQfk 2023-10-12_20:00:58.344534_wQeT
`6da1784`	2023-10-12_21:25:31.940159_eKOL 2023-10-12_21:25:31.944055_MCVM 2023-10-12_21:25:31.944068_VZXQ 2023-10-12_21:25:31.944075_ckiv 2023-10-12_21:25:31.944081_hJlx 2023-10-12_21:25:31.944086_yCru 2023-10-12_21:25:31.944092_Lsdk 2023-10-12_21:25:31.944097_zOnU 2023-10-12_21:25:31.944103_cqgF 2023-10-12_21:25:31.944108_TgsQ

redfin-30

Percentile	`15c3197`	`6da1784`	Diff	Significant (?)
p10	13.0 ±3 ms	15.3 ±3 ms	+2.31 ms (+17.8%)	NO
p25	14.0 ±4 ms	16.9 ±4 ms	+2.96 ms (+21.2%)	NO
p50	15.8 ±5 ms	19.9 ±5 ms	+4.09 ms (+25.8%)	NO
p75	19.4 ±6 ms	24.2 ±4 ms	+4.87 ms (+25.2%)	NO
p90	23.3 ±5 ms	27.3 ±5 ms	+4.10 ms (+17.6%)	NO

20 test runs in comparison

Commit	Test Runs
`15c3197`	2023-10-12_20:00:58.341116_envM 2023-10-12_20:00:58.344468_FIwZ 2023-10-12_20:00:58.344483_xSun 2023-10-12_20:00:58.344491_aLZt 2023-10-12_20:00:58.344497_uIdG 2023-10-12_20:00:58.344508_Ubra 2023-10-12_20:00:58.344515_nRAr 2023-10-12_20:00:58.344521_bsGK 2023-10-12_20:00:58.344528_TQfk 2023-10-12_20:00:58.344534_wQeT
`6da1784`	2023-10-12_21:25:31.940159_eKOL 2023-10-12_21:25:31.944055_MCVM 2023-10-12_21:25:31.944068_VZXQ 2023-10-12_21:25:31.944075_ckiv 2023-10-12_21:25:31.944081_hJlx 2023-10-12_21:25:31.944086_yCru 2023-10-12_21:25:31.944092_Lsdk 2023-10-12_21:25:31.944097_zOnU 2023-10-12_21:25:31.944103_cqgF 2023-10-12_21:25:31.944108_TgsQ

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`15c3197`	`6da1784`	Diff	Significant (?)
p10	204 ±5 ms	209 ±3 ms	+5.25 ms (+2.6%)	NO
p25	209 ±6 ms	215 ±4 ms	+6.07 ms (+2.9%)	NO
p50	217 ±6 ms	223 ±5 ms	+6.14 ms (+2.8%)	NO
p75	225 ±7 ms	233 ±7 ms	+7.63 ms (+3.4%)	NO
p90	234 ±6 ms	242 ±9 ms	+8.07 ms (+3.4%)	NO

20 test runs in comparison

Commit	Test Runs
`15c3197`	2023-10-12_20:00:58.341116_envM 2023-10-12_20:00:58.344468_FIwZ 2023-10-12_20:00:58.344483_xSun 2023-10-12_20:00:58.344491_aLZt 2023-10-12_20:00:58.344497_uIdG 2023-10-12_20:00:58.344508_Ubra 2023-10-12_20:00:58.344515_nRAr 2023-10-12_20:00:58.344521_bsGK 2023-10-12_20:00:58.344528_TQfk 2023-10-12_20:00:58.344534_wQeT
`6da1784`	2023-10-12_21:25:31.940159_eKOL 2023-10-12_21:25:31.944055_MCVM 2023-10-12_21:25:31.944068_VZXQ 2023-10-12_21:25:31.944075_ckiv 2023-10-12_21:25:31.944081_hJlx 2023-10-12_21:25:31.944086_yCru 2023-10-12_21:25:31.944092_Lsdk 2023-10-12_21:25:31.944097_zOnU 2023-10-12_21:25:31.944103_cqgF 2023-10-12_21:25:31.944108_TgsQ

redfin-30

Percentile	`15c3197`	`6da1784`	Diff	Significant (?)
p10	247 ±12 ms	270 ±6 ms	+23.2 ms (+9.4%)	NO
p25	254 ±13 ms	278 ±8 ms	+24.1 ms (+9.5%)	NO
p50	262 ±14 ms	288 ±8 ms	+25.7 ms (+9.8%)	NO
p75	272 ±16 ms	298 ±9 ms	+26.2 ms (+9.6%)	NO
p90	285 ±23 ms	312 ±11 ms	+27.4 ms (+9.6%)	NO

20 test runs in comparison

Commit	Test Runs
`15c3197`	2023-10-12_20:00:58.341116_envM 2023-10-12_20:00:58.344468_FIwZ 2023-10-12_20:00:58.344483_xSun 2023-10-12_20:00:58.344491_aLZt 2023-10-12_20:00:58.344497_uIdG 2023-10-12_20:00:58.344508_Ubra 2023-10-12_20:00:58.344515_nRAr 2023-10-12_20:00:58.344521_bsGK 2023-10-12_20:00:58.344528_TQfk 2023-10-12_20:00:58.344534_wQeT
`6da1784`	2023-10-12_21:25:31.940159_eKOL 2023-10-12_21:25:31.944055_MCVM 2023-10-12_21:25:31.944068_VZXQ 2023-10-12_21:25:31.944075_ckiv 2023-10-12_21:25:31.944081_hJlx 2023-10-12_21:25:31.944086_yCru 2023-10-12_21:25:31.944092_Lsdk 2023-10-12_21:25:31.944097_zOnU 2023-10-12_21:25:31.944103_cqgF 2023-10-12_21:25:31.944108_TgsQ

https://storage.googleapis.com/firebase-sdk-metric-reports/pkSyOFVjHE/index.html

Fix warnings so that bryan can continue to have superpowers

6d09ed6

jrothfeder changed the base branch from master to sessions-nine October 12, 2023 21:07

google-oss-bot added the size/S label Oct 12, 2023

jrothfeder requested review from mrober and bryanatkinson October 12, 2023 21:07

jrothfeder added the no-changelog label Oct 12, 2023

bryanatkinson approved these changes Oct 12, 2023

View reviewed changes

mrober approved these changes Oct 13, 2023

View reviewed changes

jrothfeder merged commit 42ec418 into sessions-nine Oct 13, 2023

jrothfeder deleted the fix-bryans-warnings branch October 13, 2023 13:32

firebase locked and limited conversation to collaborators Nov 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix a bunch of warnings on this class so that bryan can continue to have vimean superpowers. #5413

Fix a bunch of warnings on this class so that bryan can continue to have vimean superpowers. #5413

Uh oh!

jrothfeder commented Oct 12, 2023

Uh oh!

github-actions bot commented Oct 12, 2023 •

edited

Loading

Uh oh!

bryanatkinson left a comment

Uh oh!

google-oss-bot commented Oct 12, 2023

`firebase-sessions`

Uh oh!

github-actions bot commented Oct 12, 2023

Uh oh!

google-oss-bot commented Oct 12, 2023

`firebase-sessions`

Uh oh!

google-oss-bot commented Oct 12, 2023

`fire-cls`

`fire-perf`

`fire-sessions`

`timeToInitialDisplay`

Uh oh!

Uh oh!

Fix a bunch of warnings on this class so that bryan can continue to have vimean superpowers. #5413

Fix a bunch of warnings on this class so that bryan can continue to have vimean superpowers. #5413

Uh oh!

Conversation

jrothfeder commented Oct 12, 2023

Uh oh!

github-actions bot commented Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release note changes

Uh oh!

bryanatkinson left a comment

Choose a reason for hiding this comment

Uh oh!

google-oss-bot commented Oct 12, 2023

Coverage Report 1

Affected Products

firebase-sessions

Test Logs

Uh oh!

github-actions bot commented Oct 12, 2023

Unit Test Results

Uh oh!

google-oss-bot commented Oct 12, 2023

Size Report 1

Affected Products

firebase-sessions

Test Logs

Uh oh!

google-oss-bot commented Oct 12, 2023

Startup Time Report 1

Notes

Startup Times

fire-cls

fire-perf

fire-sessions

timeToInitialDisplay

Uh oh!

Uh oh!

github-actions bot commented Oct 12, 2023 •

edited

Loading

Coverage Report ¹

`firebase-sessions`

Size Report ¹

`firebase-sessions`

Startup Time Report ¹

`fire-cls`

`fire-perf`

`fire-sessions`

`timeToInitialDisplay`