Skip to content

Keep track of pending foreground before settings fetched #5482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2023
Merged

Keep track of pending foreground before settings fetched #5482

merged 1 commit into from
Oct 27, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Oct 27, 2023

Keep track of pending foreground before settings fetched to catch the first session in cold start with no settings cache.

@github-actions
Copy link
Contributor

Unit Test Results

   112 files   -    800     112 suites   - 800   4m 8s ⏱️ - 36m 38s
   993 tests  - 4 053     993 ✔️  - 4 032  0 💤  - 21  0 ❌ ±0 
1 986 runs   - 8 191  1 986 ✔️  - 8 149  0 💤  - 42  0 ❌ ±0 

Results for commit 64b1b6c. ± Comparison against base commit f884d1a.

@mrober mrober requested a review from visumickey October 27, 2023 16:36
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (f884d1a)Merge (2ce4391)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-sessions

    TypeBase (f884d1a)Merge (2ce4391)Diff
    aar?152 kB? (?)
    apk (aggressive)?373 kB? (?)
    apk (release)?2.08 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6V4nRa2hJN.html

@mrober mrober merged commit 4d935cd into sessions-nine Oct 27, 2023
@mrober mrober deleted the sessions-nine-first-session branch October 27, 2023 17:48
@firebase firebase locked and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrothfeder jrothfeder jrothfeder approved these changes

@bryanatkinson bryanatkinson bryanatkinson approved these changes

@visumickey visumickey Awaiting requested review from visumickey

Assignees
No one assigned
Labels
no-changelog size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrober @google-oss-bot @jrothfeder @bryanatkinson