Skip to content

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Apr 9, 2025

No description provided.

Copy link
Contributor

github-actions bot commented Apr 9, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-dataconnect

    Overall coverage changed from ? (9e89b28) to 14.45% (d66b586) by ?.

    62 individual files with coverage change

    FilenameBase (9e89b28)Merge (d66b586)Diff
    AlphanumericStringUtil.kt?0.00%?
    AnyValue.kt?0.00%?
    AnyValueSerializer.kt?0.00%?
    Comparisons.kt?0.00%?
    ConnectorConfig.kt?33.33%?
    CoroutineExceptionHandler.kt?50.00%?
    DataConnectAppCheck.kt?71.43%?
    DataConnectAuth.kt?71.43%?
    DataConnectCredentialsTokenManager.kt?34.12%?
    DataConnectException.kt?0.00%?
    DataConnectGrpcClient.kt?0.00%?
    DataConnectGrpcMetadata.kt?65.82%?
    DataConnectGrpcRPCs.kt?0.00%?
    DataConnectOperationException.kt?0.00%?
    DataConnectOperationFailureResponse.kt?0.00%?
    DataConnectOperationFailureResponseImpl.kt?0.00%?
    DataConnectPathSegment.kt?0.00%?
    DataConnectSettings.kt?33.33%?
    DataConnectUntypedData.kt?0.00%?
    DataConnectUntypedVariables.kt?0.00%?
    Emitters.kt?100.00%?
    ExperimentalFirebaseDataConnect.kt?0.00%?
    FirebaseDataConnect.kt?50.00%?
    FirebaseDataConnectFactory.kt?29.17%?
    FirebaseDataConnectImpl.kt?42.34%?
    FirebaseDataConnectRegistrar.kt?100.00%?
    GeneratedConnector.kt?0.00%?
    GeneratedMutation.kt?0.00%?
    GeneratedOperation.kt?0.00%?
    GeneratedQuery.kt?0.00%?
    Globals.kt?0.00%?
    JavaTimeLocalDateSerializer.kt?0.00%?
    KotlinxDatetimeLocalDateSerializer.kt?0.00%?
    LiveQueries.kt?0.00%?
    LiveQuery.kt?0.00%?
    LocalDate.kt?0.00%?
    LocalDateSerializer.kt?0.00%?
    Logger.kt?73.68%?
    LogLevel.kt?72.73%?
    MutationRef.kt?0.00%?
    MutationRefImpl.kt?12.36%?
    NullableReference.kt?40.00%?
    NullOutputStream.kt?0.00%?
    OperationRef.kt?0.00%?
    OperationRefImpl.kt?20.45%?
    OptionalVariable.kt?0.00%?
    ProtoStructDecoder.kt?0.00%?
    ProtoStructEncoder.kt?0.00%?
    ProtoUtil.kt?0.00%?
    QueryManager.kt?0.00%?
    QueryRef.kt?0.00%?
    QueryRefImpl.kt?14.08%?
    QuerySubscription.kt?0.00%?
    QuerySubscriptionImpl.kt?0.00%?
    QuerySubscriptionInternal.kt?0.00%?
    ReferenceCounted.kt?0.00%?
    RegisteredDataDeserialzer.kt?0.00%?
    SafeCollector.common.kt?66.67%?
    SequencedReference.kt?0.00%?
    SuspendingLazy.kt?31.58%?
    TimestampSerializer.kt?0.00%?
    UUIDSerializer.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Z8UD852HiE.html

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Test Results

   66 files  + 48     66 suites  +48   1m 19s ⏱️ + 1m 5s
  552 tests +466    551 ✅ +465  1 💤 +1  0 ❌ ±0 
1 104 runs  +932  1 102 ✅ +930  2 💤 +2  0 ❌ ±0 

Results for commit de80be2. ± Comparison against base commit 9e89b28.

This pull request removes 86 and adds 552 tests. Note that renamed tests count towards both.
com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.SerializationTests ‑ test Candidate serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test GenerateContentResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test Schema serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test countTokensResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test modalityTokenCount serialization as Json
com.google.firebase.vertexai.VertexAIStreamingSnapshotTests ‑ citation parsed correctly
…
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ descriptor should have expected values
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ deserialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ serialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Boolean) creates an object with the expected value
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(List) creates an object with the expected value (normal cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Map) creates an object with the expected value (normal cases)
…

@google-oss-bot
Copy link
Contributor

@rlazo rlazo merged commit 210dc02 into main Apr 9, 2025
44 of 45 checks passed
@rlazo rlazo deleted the dconeybe/dataconnect/AuthIntegrationTestBuildErrorFix branch April 9, 2025 17:55
@firebase firebase locked and limited conversation to collaborators May 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants