Disallow implicit any typings (noImplicitAny: true) #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenzlong
approved these changes
Apr 9, 2018
kevinajian
pushed a commit
that referenced
this pull request
Oct 25, 2018
Adds a Remote Config event handler `firebase.remoteconfig.onUpdate()` that will be triggered whenever a Remote Config project is updated (i.e., when a publish or rollback occurs). The event handler takes in a `TemplateVersion` object as an argument, which contains metadata about the last update that affected a Remote Config project. The PR also contains corresponding unit test and integration tests. The integration test makes use of the Remote Config REST API: https://firebase.google.com/docs/remote-config/use-config-rest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Activate the
noImplicitAnyflag in TypeScript configurations to be more strict and clear when using types. Add some missing types in the source and test files.This resolves #213 so no one needs to workaround by disabling
noImplicitAnyor usingskipLibCheckin their projects.