misc cleanup

Author: andrewbrook

packages/telemetry/src/api.test.ts

@@ -229,11 +229,12 @@ describe('Top level API', () => {
     });
 
     it('should use explicit app version when provided', () => {
-      const telemetry = {
-        ...fakeTelemetry,
-        options: {
-          appVersion: '1.0.0'
-        }
+      const telemetry = new TelemetryService(
+        fakeTelemetry.app,
+        fakeTelemetry.loggerProvider
+      );
+      telemetry.options = {
+        appVersion: '1.0.0'
       };
 
       captureError(telemetry, 'a string error');

packages/telemetry/src/service.ts

@@ -20,7 +20,7 @@ import { Telemetry, TelemetryOptions } from './public-types';
 import { LoggerProvider } from '@opentelemetry/sdk-logs';
 
 export class TelemetryService implements Telemetry, _FirebaseService {
-  _options?: TelemetryOptions;
+  private _options?: TelemetryOptions;
 
   constructor(public app: FirebaseApp, public loggerProvider: LoggerProvider) {}