-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Revert database version from POSTGRES_17 to POSTGRES_15 #9279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to roll back the default PostgreSQL database version used when provisioning new Cloud SQL instances. The change specifically targets the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts the default database version for new Cloud SQL instances from POSTGRES_17
to POSTGRES_15
. This is a straightforward change and seems reasonable, likely aimed at using a more stable and widely available database version. My main feedback is a suggestion to improve maintainability by extracting the hardcoded database version string into a constant. This would make future updates to this value easier and less error-prone.
name: args.instanceId, | ||
region: args.location, | ||
databaseVersion: "POSTGRES_17", | ||
databaseVersion: "POSTGRES_15", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hardcoded database version string was recently changed and is now being reverted, which indicates it might be a configuration value that changes over time. To improve maintainability and make future updates easier and safer, consider extracting "POSTGRES_15"
into a named constant defined at the top of the file (e.g., const DEFAULT_DATABASE_VERSION = "POSTGRES_15";
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog please
Reverts #9211