Skip to content

Conversation

fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Oct 8, 2025

Reverts #9211

Copy link
Contributor

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to roll back the default PostgreSQL database version used when provisioning new Cloud SQL instances. The change specifically targets the createInstance function, ensuring that new instances are created with POSTGRES_15 instead of the previously set POSTGRES_17, likely to maintain compatibility or stability with existing systems or supported versions.

Highlights

  • Database Version Reversion: The pull request reverts the default PostgreSQL database version used for Cloud SQL instance creation from "POSTGRES_17" back to "POSTGRES_15".
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the default database version for new Cloud SQL instances from POSTGRES_17 to POSTGRES_15. This is a straightforward change and seems reasonable, likely aimed at using a more stable and widely available database version. My main feedback is a suggestion to improve maintainability by extracting the hardcoded database version string into a constant. This would make future updates to this value easier and less error-prone.

name: args.instanceId,
region: args.location,
databaseVersion: "POSTGRES_17",
databaseVersion: "POSTGRES_15",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This hardcoded database version string was recently changed and is now being reverted, which indicates it might be a configuration value that changes over time. To improve maintainability and make future updates easier and safer, consider extracting "POSTGRES_15" into a named constant defined at the top of the file (e.g., const DEFAULT_DATABASE_VERSION = "POSTGRES_15";).

Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog please

@fredzqm fredzqm enabled auto-merge (squash) October 8, 2025 01:16
@fredzqm fredzqm merged commit 4c5477a into master Oct 8, 2025
49 checks passed
@fredzqm fredzqm deleted the fredzqm-patch-1 branch October 8, 2025 01:28
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants