Skip to content

javascript lint cleanup x3 #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 11, 2019
Merged

javascript lint cleanup x3 #1710

merged 9 commits into from
Oct 11, 2019

Conversation

bkendall
Copy link
Contributor

@bkendall bkendall commented Oct 9, 2019 •
edited
Loading

Description

Removing the guard-for-in, no-undef, and one-var exceptions for .js files.

Scenarios Tested

firebase deploy where it deleted some functions - success!

There's tiny changes in:

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Oct 9, 2019
Memeriaj
Memeriaj approved these changes Oct 9, 2019
View reviewed changes
Copy link

@Memeriaj Memeriaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, way shorter than I would have expected most of these to be.

kevinajian
kevinajian approved these changes Oct 9, 2019
View reviewed changes
@coveralls
Copy link

coveralls commented Oct 9, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 65.091% when pulling 931abb4 on bk-cleanup into c24c452 on master.

@bkendall bkendall merged commit 526dc1b into master Oct 11, 2019
@bkendall bkendall deleted the bk-cleanup branch October 11, 2019 16:10
Elgarni added a commit to Elgarni/firebase-tools that referenced this pull request Oct 11, 2019
@Elgarni
Merge branch 'master' into fix-unhandled-403-response-in-init-functions
b78b471 
* master:
  Remove unnecessary log lines (firebase#1709)
  Integration with firebase-functions 3.3.0 (firebase#1714)
  javascript lint cleanup x3 (firebase#1710)
  update lint to not fix warnings by default (firebase#1715)
  Clarify warning for unknown network requests (firebase#1711)
  Use different method for setting Firepit title (firebase#1712)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinajian kevinajian kevinajian approved these changes

@joehan joehan Awaiting requested review from joehan

@samtstern samtstern Awaiting requested review from samtstern

+1 more reviewer

@Memeriaj Memeriaj Memeriaj approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bkendall @coveralls @kevinajian @Memeriaj @googlebot