Clarify warning for unknown network requests #1711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkendall
approved these changes
Oct 10, 2019
Elgarni
added a commit
to Elgarni/firebase-tools
that referenced
this pull request
Oct 11, 2019
* master: Remove unnecessary log lines (firebase#1709) Integration with firebase-functions 3.3.0 (firebase#1714) javascript lint cleanup x3 (firebase#1710) update lint to not fix warnings by default (firebase#1715) Clarify warning for unknown network requests (firebase#1711) Use different method for setting Firepit title (firebase#1712) # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues like #1683 have shown that people find this message confusing. The new message should help people realize that this is just a warning and their network requests will still succeed.
Scenarios Tested
N/A
Sample Commands
N/A