Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template dependencies #1726

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Update template dependencies #1726

merged 2 commits into from
Oct 16, 2019

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Oct 15, 2019 •
edited
Loading

Description

Update Firebase dependencies in the firebase init functions templates to their latest versions.

Scenarios Tested

N/A

Sample Commands

N/A

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Oct 15, 2019
@coveralls
Copy link

coveralls commented Oct 15, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 65.233% when pulling 7079174 on ss-update-template-deps into 258f99b on master.

bkendall
bkendall approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@bkendall bkendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sane to me. I'd double check that init + deploy works, but LGTM.

@samtstern
Copy link
Contributor Author

Just tried both a deploy and emulation of a simple function that uses firebase-admin, everything worked as expected.

@samtstern samtstern merged commit e88bc73 into master Oct 16, 2019
Elgarni added a commit to Elgarni/firebase-tools that referenced this pull request Oct 26, 2019
@Elgarni
Merge branch 'master' into check-permissions-on-feature-init
1b20ff2 
* master:
  Un-escape new line characters from --releaseNotes arg (firebase#1739)
  update firebase-admin dev dependency (firebase#1741)
  Reject rounds=0 for SHA1 hashes (firebase#1701)
  [firebase-release] Removed change log and reset repo after 7.6.1 release
  7.6.1
  Add Firepit to cloudbuild.yaml (firebase#1637)
  lint rules cleanup x4 (firebase#1721)
  Update template dependencies (firebase#1726)
  Send correct update mask during ext:update (firebase#1724)
  add new ts rules to eslintrc (firebase#1727)
  [firebase-release] Removed change log and reset repo after 7.6.0 release
  7.6.0
  add dev tsconfig for scripts directory (firebase#1720)
  Warn when WSL users don't have Java (firebase#1717)

# Conflicts:
#	CHANGELOG.md
@samtstern samtstern deleted the ss-update-template-deps branch November 14, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkendall bkendall bkendall approved these changes

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samtstern @coveralls @bkendall @googlebot