lint rules cleanup x4 #1721
Merged
lint rules cleanup x4 #1721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
approved these changes
Oct 16, 2019
Elgarni
added a commit
to Elgarni/firebase-tools
that referenced
this pull request
Oct 26, 2019
* master: Un-escape new line characters from --releaseNotes arg (firebase#1739) update firebase-admin dev dependency (firebase#1741) Reject rounds=0 for SHA1 hashes (firebase#1701) [firebase-release] Removed change log and reset repo after 7.6.1 release 7.6.1 Add Firepit to cloudbuild.yaml (firebase#1637) lint rules cleanup x4 (firebase#1721) Update template dependencies (firebase#1726) Send correct update mask during ext:update (firebase#1724) add new ts rules to eslintrc (firebase#1727) [firebase-release] Removed change log and reset repo after 7.6.0 release 7.6.0 add dev tsconfig for scripts directory (firebase#1720) Warn when WSL users don't have Java (firebase#1717) # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes 4 more rules from the lint warnings exceptions.
The commands file is the one with the most spread/rest operators, but I'm fairly confident in those (since the commands I'm trying are, in fact, working!).
Scenarios Tested
basic usage (login, deploy)
Sample Commands