🐛 [flutterfire_ui] Android apk build fails cased by twitter plugin

[andresaraujo]

Bug report

Describe the bug
When trying to build an Android apk the build fails, even if you don't use the twitter auth provider.

Error:

e: /Users/<>/.pub-cache/hosted/pub.dartlang.org/twitter_login-4.1.0/android/src/main/kotlin/com/maru/twitter_login/TwitterLoginPlugin.kt: (76, 47): Return type of 'onNewIntent' is not a subtype of the return type of the overridden member 'protected/*protected and package*/ open fun onNewIntent(@NonNull p0: Intent): Unit defined in io.flutter.embedding.android.FlutterActivity'

Steps to reproduce

Steps to reproduce the behavior:

1. Create a default flutter app
2. Add flutter fire ui as describe in the docs: https://firebase.flutter.dev/docs/ui/auth/integrating-your-first-screen
3. Build apk

Expected behavior

It should build without problems if you are not using twitter auth provider.

---

Additional context

Add any other context about the problem here.

---

Flutter doctor

Run flutter doctor and paste the output below:

Click To Expand

[✓] Flutter (Channel master, 2.13.0-0.0.pre.380, on macOS 12.3 21E230 darwin-x64)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.1)
[✓] VS Code (version 1.66.0)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

---

Flutter dependencies

Run flutter pub deps -- --style=compact and paste the output below:

Click To Expand

Dart SDK 2.17.0-266.0.dev
Flutter SDK 2.13.0-0.0.pre.380
flutter_ui_bug 1.0.0+1

dependencies:
- cupertino_icons 1.0.4
- firebase_auth 3.3.12 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 1.14.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutterfire_ui 0.4.0 [cloud_firestore collection crypto desktop_webview_auth email_validator firebase_auth firebase_core firebase_database firebase_dynamic_links flutter flutter_facebook_auth flutter_localizations flutter_svg google_sign_in sign_in_with_apple twitter_login]

dev dependencies:
- flutter_lints 2.0.0 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]

transitive dependencies:
- async 2.8.2 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.2.0
- charcode 1.3.1
- clock 1.1.0
- cloud_firestore 3.1.11 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutter meta]
- cloud_firestore_platform_interface 5.5.2 [collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 2.6.11 [cloud_firestore_platform_interface collection firebase_core firebase_core_web flutter flutter_web_plugins js]
- collection 1.16.0
- crypto 3.0.1 [collection typed_data]
- desktop_webview_auth 0.0.6 [crypto flutter http]
- email_validator 2.0.1
- fake_async 1.3.0 [clock collection]
- firebase_auth_platform_interface 6.2.2 [firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 3.3.10 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core_platform_interface 4.2.5 [collection flutter meta plugin_platform_interface]
- firebase_core_web 1.6.1 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_database 9.0.9 [firebase_core firebase_core_platform_interface firebase_database_platform_interface firebase_database_web flutter]
- firebase_database_platform_interface 0.2.1+2 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_database_web 0.2.0+8 [firebase_core firebase_core_web firebase_database_platform_interface flutter flutter_web_plugins js]
- firebase_dynamic_links 4.1.2 [firebase_core firebase_core_platform_interface firebase_dynamic_links_platform_interface flutter meta plugin_platform_interface]
- firebase_dynamic_links_platform_interface 0.2.2+2 [firebase_core flutter meta plugin_platform_interface]
- flutter_facebook_auth 4.1.2 [flutter flutter_facebook_auth_platform_interface flutter_facebook_auth_web]
- flutter_facebook_auth_platform_interface 3.0.1 [flutter plugin_platform_interface]
- flutter_facebook_auth_web 3.0.0+1 [flutter flutter_web_plugins js flutter_facebook_auth_platform_interface]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path vector_math]
- flutter_svg 1.0.3 [flutter meta path_drawing vector_math xml]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta vector_math]
- google_sign_in 5.2.4 [flutter google_sign_in_platform_interface google_sign_in_web]
- google_sign_in_platform_interface 2.1.2 [flutter quiver]
- google_sign_in_web 0.10.0+5 [flutter flutter_web_plugins google_sign_in_platform_interface js]
- http 0.13.4 [async http_parser meta path]
- http_parser 4.0.0 [charcode collection source_span string_scanner typed_data]
- intl 0.17.0 [clock path]
- js 0.6.4
- lints 2.0.0
- matcher 0.12.11 [stack_trace]
- material_color_utilities 0.1.4
- meta 1.7.0
- path 1.8.1
- path_drawing 1.0.0 [vector_math meta path_parsing flutter]
- path_parsing 1.0.0 [vector_math meta]
- petitparser 5.0.0 [meta]
- plugin_platform_interface 2.1.2 [meta]
- quiver 3.0.1+1 [matcher]
- sign_in_with_apple 3.3.0 [flutter meta sign_in_with_apple_platform_interface sign_in_with_apple_web]
- sign_in_with_apple_platform_interface 1.0.0 [flutter plugin_platform_interface meta]
- sign_in_with_apple_web 1.0.1 [flutter flutter_web_plugins sign_in_with_apple_platform_interface js]
- sky_engine 0.0.99
- source_span 1.8.2 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- term_glyph 1.2.0
- test_api 0.4.9 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- twitter_login 4.1.0 [flutter crypto http]
- typed_data 1.3.0 [collection]
- vector_math 2.1.2
- xml 5.4.1 [collection meta petitparser]

---

[darshankawar]

Thanks for the report. I do see same behavior using plugin's official example and running flutter build apk which fails with below error log.

console error log

D:\FlutterApps\flutterfire-master\packages\flutterfire_ui\example>flutter build apk
Running "flutter pub get" in example...                            10.4s

 Building with sound null safety

Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01
Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
/D:/FlutterSDK/flutter/.pub-cache/hosted/pub.dartlang.org/flutterfire_ui-0.4.0/lib/src/auth/screens/email_verification_screen.dart:90:22: Warning: Operand of null-aware operation '!' has type 'SchedulerBinding' which excludes null.
 - 'SchedulerBinding' is from 'package:flutter/src/scheduler/binding.dart' ('/D:/FlutterSDK/flutter/packages/flutter/lib/src/scheduler/binding.dart').
    SchedulerBinding.instance!.addPostFrameCallback(_sendEmailVerification);
                     ^
Note: D:\FlutterSDK\flutter\.pub-cache\hosted\pub.dartlang.org\firebase_dynamic_links-4.1.2\android\src\main\java\io\flutter\plugins\firebase\dynamiclinks\FlutterFirebaseDynamicLinksPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: D:\FlutterSDK\flutter\.pub-cache\hosted\pub.dartlang.org\firebase_dynamic_links-4.1.2\android\src\main\java\io\flutter\plugins\firebase\dynamiclinks\FlutterFirebaseDynamicLinksPlugin.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: D:\FlutterSDK\flutter\.pub-cache\hosted\pub.dartlang.org\google_sign_in-5.2.2\android\src\main\java\io\flutter\plugins\googlesignin\GoogleSignInPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
e: D:\FlutterSDK\flutter\.pub-cache\hosted\pub.dartlang.org\twitter_login-4.0.1\android\src\main\kotlin\com\maru\twitter_login\TwitterLoginPlugin.kt: (21, 8): 'public open fun onNewIntent(Intent): Boolean defined in com.maru.twitter_login.TwitterLoginPlugin' clashes with 'protected/*protected and package*/ open fun onNewIntent(Intent): Unit defined in io.flutter.embedding.android.FlutterActivity': return types are incompatible
e: D:\FlutterSDK\flutter\.pub-cache\hosted\pub.dartlang.org\twitter_login-4.0.1\android\src\main\kotlin\com\maru\twitter_login\TwitterLoginPlugin.kt: (21, 14): Cannot infer visibility for 'fun onNewIntent(p0: Intent): Boolean'. Please specify it explicitly
e: D:\FlutterSDK\flutter\.pub-cache\hosted\pub.dartlang.org\twitter_login-4.0.1\android\src\main\kotlin\com\maru\twitter_login\TwitterLoginPlugin.kt: (76, 5): 'onNewIntent' overrides nothing

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':twitter_login:compileReleaseKotlin'.
> Compilation error. See log for more details

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 3m 40s
Running Gradle task 'assembleRelease'...                          222.6s
Gradle task assembleRelease failed with exit code 1

D:\FlutterApps\flutterfire-master\packages\flutterfire_ui\example>

I tested with current and previous version of the plugin and occurs using both and on latest master.

master, 2.13.0-0.0.pre.393

[darshankawar]

/cc @lesnitsky

[lesnitsky]

I wasn't able to reproduce this locally on stable channel both with twitter_login: ^4.0.1 and twitter_login: ^4.1.0, however it is reproducible on master

I'm going to file a bug on the twitter_login package and probably submit a PR with a fix

[0maru]

@lesnitsky
Hi.
I'm a maintainer of twitter_login.

This issue is currently being fixed.
I will fix it within a few days.

[jonahsebright]

The same problem exists for flutter build appbundle. For me the commands for building the apk/appbundle work locally but fail when run remotely with github actions.