Skip to content

Conversation

0maru
Copy link
Contributor

@0maru 0maru commented Apr 16, 2022

Description

package version dump

Related Issues

Closes #8405

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@0maru 0maru marked this pull request as ready for review April 16, 2022 14:42
@0maru 0maru requested a review from lesnitsky as a code owner April 16, 2022 14:42
@russellwheatley russellwheatley changed the title fix(ui): Bump twitter_login version fix(ui): Bump twitter_login version to fix Android build failure. Apr 21, 2022
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russellwheatley russellwheatley merged commit 4a7f47e into firebase:master Apr 21, 2022
@0maru 0maru deleted the fix-ui-deps branch April 21, 2022 09:57
@firebase firebase locked and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [flutterfire_ui] Android apk build fails cased by twitter plugin
3 participants