Skip to content

Conversation

supanadit
Copy link
Contributor

@supanadit supanadit commented Jul 6, 2020

Description

Anyone who just need firebase messaging then following the guide only and haven't experience with it, they will found an error which is at function myBackgroundMessageHandler, and they don't know what is the problem, i had got this problem twice at different project, so i don't want anyone who just follow the basic guide got an exact same error because of forgotten async word.

Related Issues

No related issue

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@Salakar Salakar changed the title [firebase_messaging] Update README.md only docs(messaging): update readme Jul 6, 2020
@Salakar Salakar merged commit 426620d into firebase:master Jul 6, 2020
@firebase firebase locked and limited conversation to collaborators Aug 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants