Skip to content

Conversation

mehmetf
Copy link
Contributor

@mehmetf mehmetf commented Jul 9, 2020

Description

These plugins should be very selective of which packages they depend on since they are core functionality to many Flutter apps. Let's avoid creating dependencies outside of the core Flutter/Dart packages.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

Copy link
Member

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this makes, I wasn't aware kIsWeb existed in flutter/foundation.dart - TIL. We'll make sure other plugins don't do this as well. Thank you for the PR

@Salakar Salakar changed the title [firebase_core] Remove universal_platform dependency and use foundation functions chore(firebase_core): remove dependency on 'universal_platform' Jul 9, 2020
@Salakar Salakar merged commit 9c9faba into firebase:master Jul 9, 2020
@kroikie kroikie self-assigned this Jul 9, 2020
@kroikie kroikie self-requested a review July 9, 2020 13:08
@firebase firebase locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants