Skip to content

chore(firebase_core): remove dependency on 'universal_platform' #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2020
Merged

chore(firebase_core): remove dependency on 'universal_platform' #2916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../firebase_core/firebase_core_platform_interface/lib/firebase_core_platform_interface.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ library firebase_core_platform_interface;
import 'dart:async';

import 'package:flutter/cupertino.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart';
import 'package:meta/meta.dart' show required;
import 'package:plugin_platform_interface/plugin_platform_interface.dart';
import 'package:quiver/core.dart';
import 'package:universal_platform/universal_platform.dart';

part 'src/firebase_core_exceptions.dart';

Expand Down
6 changes: 3 additions & 3 deletions ...ages/firebase_core/firebase_core_platform_interface/lib/src/firebase_core_exceptions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,19 @@ FirebaseException noDefaultAppInitialization() {
FirebaseException coreNotInitialized() {
String message;

if (UniversalPlatform.isWeb) {
if (kIsWeb) {
message =
'''Firebase has not been correctly initialized. Have you added the Firebase import scripts to your index.html file?

View the Web Installation documentation for more information: https://firebaseextended.github.io/flutterfire/docs/installation/web
''';
} else if (UniversalPlatform.isAndroid) {
} else if (defaultTargetPlatform == TargetPlatform.android) {
message =
'''Firebase has not been correctly initialized. Have you added the "google-services.json" file to the project?

View the Android Installation documentation for more information: https://firebaseextended.github.io/flutterfire/docs/installation/android
''';
} else if (UniversalPlatform.isIOS) {
} else if (defaultTargetPlatform == TargetPlatform.iOS) {
message =
'''Firebase has not been correctly initialized. Have you added the "GoogleService-Info.plist" file to the project?

Expand Down
1 change: 0 additions & 1 deletion packages/firebase_core/firebase_core_platform_interface/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ dependencies:
meta: ^1.1.8
plugin_platform_interface: ^1.0.2
quiver: ">=2.0.0 <3.0.0"
universal_platform: ^0.1.3

dev_dependencies:
pedantic: ^1.8.0
Expand Down