Skip to content

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Sep 8, 2021

Description

Ensure WidgetsFlutterBinding.ensureInitialized(); is called within runZonedGuard.

Related Issues

fixes #6964

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Sep 8, 2021
@russellwheatley russellwheatley changed the title fix(crashlytics): fix example chore(crashlytics): fix example to include "ensureInitialized" within runZonedGuard Sep 9, 2021
@russellwheatley russellwheatley changed the title chore(crashlytics): fix example to include "ensureInitialized" within runZonedGuard chore(crashlytics): fix example to include "ensureInitialized" within runZonedGuarded Sep 9, 2021
@russellwheatley russellwheatley merged commit f0e6be7 into master Sep 9, 2021
@russellwheatley russellwheatley deleted the @russell/revert-crash-example branch September 9, 2021 15:46
@tek08 tek08 mentioned this pull request Oct 6, 2021
10 tasks
@firebase firebase locked and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [firebase_crashlytics] Getting "Unhandled Exception: [core/no-app] No Firebase App '[DEFAULT]' has been created - call Firebase.initializeApp()"

2 participants