Skip to content

Conversation

andrewheard
Copy link
Contributor

  • Added references to the zip frameworks in the FirebaseAIExample Xcode project in a Firebase directory (this aligns with where they are extracted in the zip quickstart tests in firebase-ios-sdk.
  • Updated imports to use import FirebaseAILogic when available. The #if canImport(FirebaseAILogic) can be removed after the rename is released.

@andrewheard andrewheard requested a review from ncooke3 September 30, 2025 17:24
Copy link

Summary of Changes

Hello @andrewheard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the FirebaseAIExample Xcode project to correctly integrate with a new framework structure, specifically addressing the renaming of the FirebaseAI module to FirebaseAILogic. It ensures that the example project properly references and embeds the necessary Firebase .xcframework files, preparing it for building and running with the updated dependencies.

Highlights

  • Xcode Project Updates: The FirebaseAIExample Xcode project has been updated to include references to several Firebase .xcframework files, ensuring proper linking and embedding of these dependencies for zip-based distribution.
  • Conditional Module Imports: Swift source files across the example project have been modified to conditionally import FirebaseAILogic if available, falling back to FirebaseAI. This change anticipates a module rename and ensures compatibility during the transition period.
  • Framework Organization: A new 'Firebase' group has been added to the Xcode project to logically organize the newly referenced Firebase .xcframework dependencies, aligning with the structure used in quickstart tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds references to zipped frameworks in the Xcode project and updates Swift files to conditionally import FirebaseAILogic or FirebaseAI. The changes look good overall. I've added a few suggestions to improve the maintainability of the Xcode project file by sorting framework lists. I also suggested a way to centralize the conditional import logic to reduce code duplication across the Swift files, which would make the eventual cleanup easier.

@andrewheard andrewheard merged commit 0e9fe76 into main Sep 30, 2025
7 checks passed
@andrewheard andrewheard deleted the ah/firebaseai-qs-zip-folder branch September 30, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants