Skip to content

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Sep 30, 2025

This is a partial revert of #1772. We don't need the placeholder Firebase folder and references because https://github.com/firebase/quickstart-ios/blob/fe0b2640e883054647f16083aa835bf6388d7071/scripts/add_framework_script.rb adds them. This resulted in error: Unexpected duplicate tasks.

The #if canImport(FirebaseAILogic) parts of #1772 are still necessary and have not been reverted.

Copy link

Summary of Changes

Hello @andrewheard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request partially reverts a previous change by removing redundant placeholder configurations for Firebase frameworks within the FirebaseAIExample.xcodeproj file. The project previously included manual references to various Firebase and GoogleUtilities xcframeworks, along with an "Embed Frameworks" build phase and a "Firebase" group. These manual entries are no longer necessary because an existing script automatically adds the required frameworks. This change simplifies the Xcode project structure and removes clutter, ensuring that framework management is consistently handled by the automation script.

Highlights

  • Xcode Project Cleanup: Removed numerous placeholder references to Firebase and GoogleUtilities xcframeworks from the project.pbxproj file, including FirebaseAILogic.xcframework, FirebaseCore.xcframework, and GoogleUtilities.xcframework.
  • Build Phase Streamlining: Eliminated the 'Embed Frameworks' build phase and associated framework references, as these are now handled by an existing script.
  • Placeholder Group Removal: Deleted the 'Firebase' PBXGroup and its contents, which served as a placeholder for framework organization within the project.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the placeholder Firebase folder and its associated framework references from the Xcode project file. The changes are a partial revert, intended to allow a script to manage these dependencies, which is a good practice for project maintainability and avoiding merge conflicts. The deletions are consistent and complete across the project.pbxproj file. The change is a positive cleanup, and I have no further recommendations.

@andrewheard andrewheard requested a review from ncooke3 September 30, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants