Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Convert CommandBar to JSX #3614

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

darkwing
Copy link
Contributor

No description provided.

@@ -68,20 +68,24 @@ function formatKey(action) {
}

function debugBtn(onClick, type, className, tooltip, disabled = false) {
Copy link
Contributor

@wldcordeiro wldcordeiro Aug 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe function debugBtn({ type, className, tooltip, ...rest }) then you can make that block below

return (
  <button className={classnames(type, className)} title={tooltip} aria-label={tooltip} {...rest}>
    {Svg(type)}
  </button>
);

)

@codecov
Copy link

codecov bot commented Aug 10, 2017

Codecov Report

Merging #3614 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3614      +/-   ##
==========================================
- Coverage   54.56%   54.51%   -0.05%     
==========================================
  Files         120      120              
  Lines        4750     4747       -3     
  Branches      981      982       +1     
==========================================
- Hits         2592     2588       -4     
- Misses       2158     2159       +1
Impacted Files Coverage Δ
src/actions/ast.js 76.78% <0%> (-1.79%) ⬇️
src/components/shared/SearchInput.js 92.59% <0%> (-0.75%) ⬇️
src/components/shared/ResultList.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ebb3de...d7e2ee4. Read the comment docs.

@darkwing
Copy link
Contributor Author

Good shout, updated.

@jasonLaster jasonLaster merged commit 00d4338 into firefox-devtools:master Aug 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants