Multi threading on Lelantus-sigma prover and sigma/lelantus batch verification #1058

levonpetrosyan93 · 2021-08-01T13:24:22Z

Adding simple thread pool,
Applying multithrading on Lelantus-sigma prover
Applying multithrading on batch verification during sync/reindex.

lgtm-com · 2021-08-01T16:25:14Z

This pull request fixes 3 alerts when merging e26a7fd into dbce40b - view on LGTM.com

fixed alerts:

3 for Unused static function

a-bezrukov · 2021-08-12T03:08:54Z

Thread sanitizer does not report anything new for the batching.

reubenyap · 2021-12-01T05:31:18Z

Could you post the before/after benchmarks here?

levonpetrosyan93 · 2021-12-19T22:22:32Z

Benchmarking on Lelantus for creation of multiple sigma proofs
Running on i7-11700K 3.60GHz × 16

number of coins 1, parallel proof time 1624, regular proof time 1616
number of coins 2, parallel proof time 1672, regular proof time 3155
number of coins 8, parallel proof time 2046, regular proof time 12598
number of coins 12 parallel proof time 2602 regular proof time 18833
number of coins 16 parallel proof time 3078 regular proof time 24985
number of coins 20 parallel proof time 4719 regular proof time 31159

levoncrypto · 2021-12-27T14:44:26Z

src/liblelantus/threadpool.h

+        std::list<std::thread> threadsToJoin;
+
+        {
+            std::unique_lock<std::mutex> lock(task_queue_mutex);


use std::scoped_lock here (if we have C++17, if no then std::lock_guard)

levoncrypto · 2021-12-27T14:57:55Z

src/liblelantus/threadpool.h

+
+    void ThreadProc() {
+        for (;;) {
+            std::packaged_task<Result()> job;


remove this line

and also remove brackets

levoncrypto · 2021-12-27T14:58:27Z

src/liblelantus/threadpool.h

+                    }
+                    break;
+                }
+                job = std::move(task_queue.front());


make this line
std::packaged_task<Result()> job (std::move(task_queue.front()));

levoncrypto · 2022-01-01T10:38:54Z

src/liblelantus/threadpool.h

+        std::packaged_task<Result()> packagedTask(std::move(task));
+        std::future<Result> ret = packagedTask.get_future();
+
+        std::unique_lock<std::mutex> lock(task_queue_mutex);


use std::scoped_lock here (if we have C++17, if no then std::lock_guard)

levoncrypto · 2022-01-01T10:48:34Z

src/batchproof_container.cpp


-        lelantus::SigmaExtendedVerifier sigmaVerifier(params->get_g(), params->get_sigma_h(), params->get_sigma_n(),
-                                            params->get_sigma_m());
+                lelantus::SigmaExtendedVerifier sigmaVerifier(params->get_g(), params->get_sigma_h(), params->get_sigma_n(),


I think you can move this outside of loop

levoncrypto · 2022-01-01T10:51:12Z

src/liblelantus/lelantus_prover.cpp

+    parallelTasks.reserve(threadsMaxCount);
+    ParallelOpThreadPool<void> threadPool(threadsMaxCount);
+
+    std::vector<std::vector<GroupElement>> C_;


you can store only one array, and clear() it at the start of each iteration

We are passing all values by reference, storing and clearing will not work.

levoncrypto · 2022-01-01T10:52:21Z

src/liblelantus/lelantus_prover.cpp

+                Yk[i].resize(params->get_sigma_m());
+                a[i].resize(params->get_sigma_n() * params->get_sigma_m());
+
+                auto& sigma_i = sigma[i];


const auto&

no, we need to fill i-th vector

lgtm-com · 2022-02-21T12:13:02Z

This pull request introduces 2 alerts when merging a75b339 into d73a892 - view on LGTM.com

new alerts:

2 for Unused static function

firstcryptoman

It looks good for me.

psolstice · 2022-02-28T06:17:15Z

src/liblelantus/lelantus_prover.cpp

+        for (auto& th : parallelTasks) {
+            try {
+                th.get();
+            } catch (std::exception& except) {


if exception other than std::exception is thrown from inside prover.sigma_commit() it'll be rethrown on th.get(). Imagine situation where the first task in the list results in exception which is not supposed to abort the program. We're getting out of LelantusProver::generate_sigma_proofs while all other tasks are still running and referencing local variables. This will result in segfault. If sigma_commit() can throw you need to wrap it into catch

also in case of client shutdown (even graceful!) all the threads are cancelled (boost::thread_group::interrupt_all()). In this case th.get() will throw boost exception, call frame will cease to exist and you'll get corrupted data or segfault

psolstice · 2022-03-05T05:34:53Z

src/liblelantus/lelantus_prover.cpp

+                isFail = true;
+            }  catch (...) {
+                LogPrintf("Lelantus proof creation failed.");
+                isFail = true;


look for docs there
https://www.boost.org/doc/libs/1_54_0/doc/html/thread/thread_management.html#thread.thread_management.tutorial.interruption

you can't use catch(...) here (without rethrowing at least). This this catch boost::thread_interrupted and then throw std::runtime_error. Meaning every time you gracefully shutdown there will be runtime error

please use the method from zerocoin code to block thread interruption while in function

lgtm-com · 2022-03-07T05:43:33Z

This pull request introduces 1 alert when merging 9ae34d9 into 9f2c3b9 - view on LGTM.com

new alerts:

1 for Commented-out code

psolstice · 2022-03-10T09:52:35Z

src/batchproof_container.cpp

+    std::size_t threadsMaxCount = std::min((unsigned int)sigmaProofs.size(), boost::thread::hardware_concurrency());
+    std::vector<boost::future<bool>> parallelTasks;
+    parallelTasks.reserve(threadsMaxCount);
+    ParallelOpThreadPool<bool> threadPool(threadsMaxCount);


DoNotDisturb here? and everywhere where ParallelOpThreadPool is used

We added multithreading in Lelantus-sigma roof creation code and batch proving code.
1 Added DoNotDisturb here for proof creation, I think we need it inside the function which is called in thread. https://github.com/firoorg/firo/pull/1058/files#diff-35b15f4d3b021c6dc41983092fa0d3666801234fe9f9ce790b41c65297a68483R32
2 Fir batching I don't think we need don't disturb as shutdown waits until batch verification finishes, https://github.com/firoorg/firo/blob/78e29d68b7354be702965fdd4f033709750776e5/src/init.cpp#L258

lgtm-com · 2022-03-14T05:16:34Z

This pull request introduces 3 alerts when merging 7e19959 into 78e29d6 - view on LGTM.com

new alerts:

2 for Unused static function
1 for Commented-out code

psolstice · 2022-03-15T15:38:52Z

src/batchproof_container.cpp

-        auto params = sigma::Params::get_default();
-        sigma::SigmaPlusVerifier<Scalar, GroupElement> sigmaVerifier(params->get_g(), params->get_h(), params->get_n(), params->get_m());
+                parallelTasks.emplace_back(threadPool.PostTask([=]() {
+                    DoNotDisturb dnd;


dnd should be in the same function frame that gets std::future result, not in lambda

lgtm-com · 2022-03-16T01:18:51Z

This pull request introduces 1 alert when merging 90b5b59 into 78e29d6 - view on LGTM.com

new alerts:

1 for Commented-out code

…ification (#1058) * Multi-core optimization to lelantus-sigma proof creation * Multithreading applied on batch verification * Using another thread pool implementation * Review comments applied * Exeption handling fixed * Fixed bug in threadpool, using boost thread * Exception handling refactored * Fixed crash on shutdown * Review comment applied * Moved DoNotDisturb into right place.

levonpetrosyan93 added 2 commits July 28, 2021 21:27

Multi-core optimization to lelantus-sigma proof creation

f7eaeda

Multithreading applied on batch verification

e26a7fd

levonpetrosyan93 requested review from psolstice and a-bezrukov August 1, 2021 13:24

levonpetrosyan93 changed the title ~~Multithreading on Lelantus-sigma prover and sigma/lelantus batch verification~~ Multi threading on Lelantus-sigma prover and sigma/lelantus batch verification Aug 1, 2021

Using another thread pool implementation

a2b812b

Merge branch 'master' into multithreading

f2fc234

reubenyap added the Lelantus label Sep 26, 2021

reubenyap added this to the v0.14.9.1 Maintenance Release milestone Sep 26, 2021

Merge branch 'master' into multithreading

888976b

Merge branch 'master' into multithreading

c3ad396

levonpetrosyan93 requested review from levoncrypto and removed request for a-bezrukov December 27, 2021 12:48

levoncrypto requested changes Jan 1, 2022

View reviewed changes

Review comments applied

545a58c

levonpetrosyan93 requested a review from levoncrypto January 12, 2022 13:38

levoncrypto previously approved these changes Jan 16, 2022

View reviewed changes

Merge branch 'master' into multithreading

fc3b292

levonpetrosyan93 dismissed levoncrypto’s stale review via fc3b292 February 17, 2022 20:37

levonpetrosyan93 requested review from firstcryptoman and levoncrypto and removed request for levoncrypto February 21, 2022 00:18

Merge branch 'master' into multithreading

a75b339

firstcryptoman previously approved these changes Feb 23, 2022

View reviewed changes

psolstice requested changes Feb 28, 2022

View reviewed changes

levonpetrosyan93 dismissed firstcryptoman’s stale review via 7c7992d March 4, 2022 13:47

Exeption handling fixed

63d68d0

levonpetrosyan93 force-pushed the multithreading branch from 7c7992d to 63d68d0 Compare March 4, 2022 13:58

Merge branch 'master' into multithreading

98ea41d

psolstice requested changes Mar 5, 2022

View reviewed changes

levonpetrosyan93 added 3 commits March 7, 2022 06:00

Fixed bug in threadpool, using boost thread

ac452e5

Exception handling refactored

f3918af

Fixed crash on shutdown

9ae34d9

reubenyap requested a review from psolstice March 7, 2022 07:12

psolstice requested changes Mar 10, 2022

View reviewed changes

Review comment applied

7e19959

psolstice requested changes Mar 15, 2022

View reviewed changes

Moved DoNotDisturb into right place.

90b5b59

psolstice approved these changes Mar 16, 2022

View reviewed changes

reubenyap merged commit 904984e into master Mar 18, 2022

reubenyap deleted the multithreading branch March 18, 2022 00:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi threading on Lelantus-sigma prover and sigma/lelantus batch verification #1058

Multi threading on Lelantus-sigma prover and sigma/lelantus batch verification #1058

levonpetrosyan93 commented Aug 1, 2021

lgtm-com bot commented Aug 1, 2021

a-bezrukov commented Aug 12, 2021

reubenyap commented Dec 1, 2021

levonpetrosyan93 commented Dec 19, 2021 •

edited

Loading

levoncrypto Dec 27, 2021

levonpetrosyan93 Jan 11, 2022

levoncrypto Dec 27, 2021

levoncrypto Dec 27, 2021

levonpetrosyan93 Jan 11, 2022

levoncrypto Dec 27, 2021

levonpetrosyan93 Jan 11, 2022

levoncrypto Jan 1, 2022

levonpetrosyan93 Jan 11, 2022

levoncrypto Jan 1, 2022

levonpetrosyan93 Jan 11, 2022

levoncrypto Jan 1, 2022

levonpetrosyan93 Jan 11, 2022

levoncrypto Jan 1, 2022

levonpetrosyan93 Jan 11, 2022

lgtm-com bot commented Feb 21, 2022

firstcryptoman left a comment

psolstice Feb 28, 2022

psolstice Feb 28, 2022

psolstice Mar 5, 2022

lgtm-com bot commented Mar 7, 2022

psolstice Mar 10, 2022

levonpetrosyan93 Mar 11, 2022 •

edited

Loading

lgtm-com bot commented Mar 14, 2022

psolstice Mar 15, 2022

levonpetrosyan93 Mar 15, 2022

lgtm-com bot commented Mar 16, 2022

Multi threading on Lelantus-sigma prover and sigma/lelantus batch verification #1058

Multi threading on Lelantus-sigma prover and sigma/lelantus batch verification #1058

Conversation

levonpetrosyan93 commented Aug 1, 2021

lgtm-com bot commented Aug 1, 2021

a-bezrukov commented Aug 12, 2021

reubenyap commented Dec 1, 2021

levonpetrosyan93 commented Dec 19, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgtm-com bot commented Feb 21, 2022

firstcryptoman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgtm-com bot commented Mar 7, 2022

Choose a reason for hiding this comment

levonpetrosyan93 Mar 11, 2022 • edited Loading

Choose a reason for hiding this comment

lgtm-com bot commented Mar 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgtm-com bot commented Mar 16, 2022

levonpetrosyan93 commented Dec 19, 2021 •

edited

Loading

levonpetrosyan93 Mar 11, 2022 •

edited

Loading