don't assume fields/data

Author: orthagonal

index.js

@@ -13,9 +13,12 @@ const register = (server, pluginOptions) => {
       return h.continue;
     }
     if (request.headers.accept === 'text/csv') {
-      const routeOptions = request.route.settings.plugins['hapi-transform-csv'] || {};
+      const input = Object.assign({}, pluginOptions, request.route.settings.plugins['hapi-transform-csv'] || {});
+      // get the fields:
+      input.fields = Array.from(new Set(response.source.reduce((memo, item) => memo.concat(Object.keys(item)), [])));
+      input.data = response.source;
       // json2csv may throw an error if not formatted correctly:
-      return h.response(json2csv(Object.assign({}, pluginOptions, routeOptions, response.source)));
+      return h.response(json2csv(input));
     }
     return h.continue;
   });

tests/output1.txt

@@ -0,0 +1,4 @@
+"car","price","color"
+"Audi",40000,"blue"
+"BMW",35000,"black"
+"Porsche",60000,"green"

tests/output2.txt

@@ -0,0 +1,4 @@
+$car$_$price$_$color$
+$Audi$_40000_$blue$
+$BMW$_35000_$black$
+$Porsche$_60000_$green$

tests/test.csv.js

@@ -1,31 +1,30 @@
 const Hapi = require('hapi');
 const tap = require('tap');
 const plugin = require('../index');
+const fs = require('fs');
+const path = require('path');
 
 tap.test('can configure a route to return csv instead of json', async(t) => {
   const server = await new Hapi.Server({ port: 8080 });
   server.route({
     method: 'get',
     path: '/normal',
     handler(request, h) {
-      return {
-        fields: ['car', 'price', 'color'],
-        data: [
-          {
-            car: 'Audi',
-            price: 40000,
-            color: 'blue'
-          }, {
-            car: 'BMW',
-            price: 35000,
-            color: 'black'
-          }, {
-            car: 'Porsche',
-            price: 60000,
-            color: 'green'
-          }
-        ]
-      };
+      return [
+        {
+          car: 'Audi',
+          price: 40000,
+          color: 'blue'
+        }, {
+          car: 'BMW',
+          price: 35000,
+          color: 'black'
+        }, {
+          car: 'Porsche',
+          price: 60000,
+          color: 'green'
+        }
+      ];
     }
   });
 
@@ -64,10 +63,7 @@ tap.test('can configure a route to return csv instead of json', async(t) => {
   });
   t.equal(csvResponse.statusCode, 200, 'returns HTTP OK');
   t.equal(typeof csvResponse.result, 'string', 'returns a string value');
-  const rows = csvResponse.result.split('\n');
-  t.notEqual(rows[0].indexOf('car'), -1, 'top row of csv is the headers');
-  t.notEqual(rows[0].indexOf('price'), -1, 'top row of csv is the headers');
-  t.notEqual(rows[0].indexOf('color'), -1, 'top row of csv is the headers');
+  t.equal(csvResponse.result, fs.readFileSync(path.join(__dirname, 'output1.txt'), 'utf-8'), 'returns correct output');
   const jsonResponse = await server.inject({
     method: 'get',
     url: '/normal'
@@ -129,8 +125,7 @@ tap.test('will pass config options to json2csv', async(t) => {
     url: '/path1.csv'
   });
   t.equal(csvResponse.statusCode, 200, 'returns HTTP OK');
-  t.equal(csvResponse.result.indexOf('$car$'), 0, 'applied the json2csv route options');
-  t.equal(csvResponse.result.indexOf('$car$_$price$_$color$'), 0, 'applied the json2csv plugin options');
+  t.equal(csvResponse.result, fs.readFileSync(path.join(__dirname, 'output2.txt'), 'utf-8'), 'returns correct output');
   await server.stop();
   t.end();
 });