Show autosuggestions when (left prompt + command) exceed right prompt #7035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faho
reviewed
May 24, 2020
src/screen.cpp
Outdated
| @@ -971,16 +973,37 @@ static screen_layout_t compute_layout(screen_t *s, size_t screen_width, | |||
| } | |||
|
|
|||
| // Case 3 | |||
| if (!done) { | |||
| calculated_width = left_prompt_width + first_command_line_width + autosuggest_total_width; | |||
There was a problem hiding this comment.
The indentation here is off, we use 4 space indents, not tabs.
See also build_tools/style.fish
There was a problem hiding this comment.
Fixed whitespace in 812095b
|
Yeah, that works nicely. Thanks, merged! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when the (left prompt + command) exceeds the right prompt autosuggestions are not shown. With this change autosuggestions are shown. Existing tests look green:
https://travis-ci.org/github/ksralgp/fish-shell/builds/690675896
Fixes issue #6948
TODOs: