refactor: use &TxHash in Bundle trait methods #39
+20
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `is_allowed_to_fail` and `is_optional` to accept `&TxHash` instead of `TxHash`. These methods are primarily used for lookups in collections, and accepting a reference allows implementations to use methods like `Vec::contains()` and `HashSet::contains()` directly without requiring callers to copy the hash.
karim-agha
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
is_allowed_to_failandis_optionalto accept&TxHashinstead ofTxHash. These methods are primarily used for lookups in collections, and accepting a reference allows implementations to use methods likeVec::contains()andHashSet::contains()directly without requiring callers to copy the hash.this gets rid of copies when the bundle is executed:
https://github.com/mattsse/rblib/blob/f8f44b448ac061456d9df23b449bf9ed9d967ce6/src/payload/exec.rs#L207-L210