perf(payload): Avoid redundant encoding of bundle transactions #41
Conversation
Signed-off-by: 7suyash7 <suyashnyn1@gmail.com>
Signed-off-by: 7suyash7 <suyashnyn1@gmail.com>
Thank you and Done! |
| fn executables<'a>( | ||
| &'a self, | ||
| ) -> Box< | ||
| dyn Iterator<Item = WithEncoded<&'a Recovered<types::Transaction<P>>>> + 'a, | ||
| > { |
There was a problem hiding this comment.
maybe you can even use impl Iterator here
but unsure if this trait should be object safe
There was a problem hiding this comment.
I think impl Iterator is good.
To keep Bundle object safe, we can consider moving it in a BundleExt in payload::ext
There was a problem hiding this comment.
Hi, I tried the impl Iterator and BundleExt suggestions, but hit a compiler error due to different iterator types between the optimised and fallback paths.
I switched to using a GAT on the Bundle trait instead. Let me know what you think of this approach.
| /// By default, this wraps the plain `Recovered` transactions. Implementors | ||
| /// that store pre-encoded bytes can override this to provide the more | ||
| /// efficient `WithEncoded` wrapper. | ||
| fn executables<'a>( |
There was a problem hiding this comment.
As this could be slightly confusing with the concept of Executable in the payload API, we could rename this function to something like fn transactions_encoded instead
| fn executables<'a>( | ||
| &'a self, | ||
| ) -> Box< | ||
| dyn Iterator<Item = WithEncoded<&'a Recovered<types::Transaction<P>>>> + 'a, | ||
| > { |
There was a problem hiding this comment.
I think impl Iterator is good.
To keep Bundle object safe, we can consider moving it in a BundleExt in payload::ext
Signed-off-by: 7suyash7 <suyashnyn1@gmail.com>
4 participants
Leverages pre-encoded bytes from FlashbotsBundle to skip redundant transaction encoding. This improves performance, especially for the OP-Stack.