-
Notifications
You must be signed in to change notification settings - Fork 530
docker: upgrade apache-tvm-ffi==0.1.0b15 in docker container #1857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @yzh119, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the stability of the Docker build environment by updating a critical dependency. The primary goal is to integrate a newer version of Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades the apache-tvm-ffi
package to version 0.1.0b15
in the Docker build script to incorporate a memory leak fix. The change is straightforward and correct. I've added a couple of suggestions to combine consecutive pip3 install
commands within the script. This will improve efficiency by reducing the number of processes launched and also enhances the script's readability.
pip3 install --upgrade cuda-python==13.0 | ||
pip3 install "nvidia-cudnn-cu13>=9.12.0.46" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better efficiency and readability, you can combine these two pip3 install
commands into a single one. This reduces the number of separate processes being invoked.
pip3 install --upgrade cuda-python==13.0 | |
pip3 install "nvidia-cudnn-cu13>=9.12.0.46" | |
pip3 install --upgrade cuda-python==13.0 "nvidia-cudnn-cu13>=9.12.0.46" |
pip3 install --upgrade cuda-python==12.* | ||
pip3 install "nvidia-cudnn-cu12>=9.11.0.98" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the if
branch, you can combine these two pip3 install
commands into a single one for better efficiency and readability.
pip3 install --upgrade cuda-python==12.* | |
pip3 install "nvidia-cudnn-cu12>=9.11.0.98" | |
pip3 install --upgrade cuda-python==12.* "nvidia-cudnn-cu12>=9.11.0.98" |
📌 Description
TVM-FFI made a new release with bugfix on potential memory leak:
apache/tvm-ffi#87
This PR bumps the apache-tvm-ffi version in docker container.
🔍 Related Issues
apache/tvm-ffi#87
🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete.
✅ Pre-commit Checks
pre-commit
by runningpip install pre-commit
(or used your preferred method).pre-commit install
.pre-commit run --all-files
and fixed any reported issues.🧪 Tests
unittest
, etc.).Reviewer Notes