Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release-ci-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
- main
paths:
- 'docker/**'
- '.github/workflows/release-ci-docker.yml'
pull_request:
branches:
- main
Expand Down
10 changes: 5 additions & 5 deletions docker/install/install_python_packages.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@ CUDA_VERSION=${1:-cu128}

pip3 install torch --index-url https://download.pytorch.org/whl/${CUDA_VERSION}
pip3 install requests responses ninja pytest numpy scipy build nvidia-ml-py cuda-python einops nvidia-nvshmem-cu12
pip3 install 'apache-tvm-ffi==0.1.0b11'
pip3 install 'apache-tvm-ffi==0.1.0b15'
pip3 install nvidia-cutlass-dsl
pip3 install 'nvidia-cudnn-frontend>=1.13.0'

# Install cudnn package based on CUDA version
if [[ "$CUDA_VERSION" == *"cu13"* ]]; then
pip3 install --upgrade cuda-python==13.0
pip3 install "nvidia-cudnn-cu13>=9.12.0.46"
pip3 install --upgrade cuda-python==13.0
pip3 install "nvidia-cudnn-cu13>=9.12.0.46"
Comment on lines +33 to +34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better efficiency and readability, you can combine these two pip3 install commands into a single one. This reduces the number of separate processes being invoked.

Suggested change
pip3 install --upgrade cuda-python==13.0
pip3 install "nvidia-cudnn-cu13>=9.12.0.46"
pip3 install --upgrade cuda-python==13.0 "nvidia-cudnn-cu13>=9.12.0.46"

else
pip3 install --upgrade cuda-python==12.*
pip3 install "nvidia-cudnn-cu12>=9.11.0.98"
pip3 install --upgrade cuda-python==12.*
pip3 install "nvidia-cudnn-cu12>=9.11.0.98"
Comment on lines +36 to +37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the if branch, you can combine these two pip3 install commands into a single one for better efficiency and readability.

Suggested change
pip3 install --upgrade cuda-python==12.*
pip3 install "nvidia-cudnn-cu12>=9.11.0.98"
pip3 install --upgrade cuda-python==12.* "nvidia-cudnn-cu12>=9.11.0.98"

fi