sdk_container: publish the SDK on a Docker registry #439
Conversation
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
|
|
||
| # Docker images are pushed in the container registry. | ||
| for a in all amd64 arm64; do | ||
| docker push "${CONTAINER_REGISTRY}/flatcar-sdk-${a}":"${docker_vernum}" |
There was a problem hiding this comment.
For the future: In case we build something releasable every night, I wouldn't publish it directly here in this job but do the SDK publishing in the release job which is run manually - otherwise we clutter the registry too much.
For now it's ok to do it here, no problem.
There was a problem hiding this comment.
Or as Gabriel suggested, we use garbage collection to remove the unused images after one week, only keeping those that are used in the version.txt files of the releases under CHANNEL.release.flatcar-linux.net
There was a problem hiding this comment.
quickly checked, but I don't see a limitation for GH Container Registry? In that case, we could simply push each built SDK, without pruning them.
There was a problem hiding this comment.
Deleting development SDKs makes sense to give people a chance to mirror the registry efficiently and also helps to reduce the environmental impact ;)
There was a problem hiding this comment.
I just been through the release job - I think that would make more sense to move theses lines directly into the release script.
There was a problem hiding this comment.
As you like. One argument for doing it here would be that we could skip the tar ball import to create the local Docker image which takes a couple of minutes. Not sure if this needs some other changes in the pipeline and we would still want to keep the possibility to work without a registry, I think?
There was a problem hiding this comment.
Yes, let's do this.
|
closed in favor of: #475 |
Signed-off-by: Mathieu Tortuyaux mtortuyaux@microsoft.com
On the CI side, we need to generate a PAT for the Flatcar buildbot and pass it from Jenkins to the script.
Related to: flatcar/Flatcar#739