-
Notifications
You must be signed in to change notification settings - Fork 69
ci-automation/release.sh: Run plume to release cloud images #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
added a commit
to flatcar/mantle
that referenced
this pull request
Sep 15, 2022
The cloudformation update is done with the aws tool as of now, and we need it in the build pipeline flatcar/scripts#475 until we move this logic into plume.
This was referenced Sep 15, 2022
3cd2063
to
d808276
Compare
tormath1
reviewed
Sep 19, 2022
pothos
commented
Sep 19, 2022
Tempted to also add the Azure community gallery upload but maybe let's keep that for later. |
pothos
commented
Sep 19, 2022
pothos
commented
Sep 19, 2022
pothos
commented
Sep 19, 2022
pothos
commented
Sep 19, 2022
e8d01da
to
5cfd126
Compare
1e5e199
to
f4d3eb6
Compare
pothos
commented
Sep 21, 2022
f4d3eb6
to
f4b7745
Compare
tormath1
reviewed
Sep 22, 2022
751e553
to
d007356
Compare
The mantle plume tool has two steps, pre-release is the mere upload and release is the publication. In the past this was used to run the tests inbetween but we don't do this anymore. Run plume pre-release and release in a single job. Since plume can't push to GCS in our case, we upload the files to bincache. Also do the cloudformation update which was previously done in flatcar-build-scripts but could only be run after the sync to Origin. It requires the "aws" tool in the mantle container until we implement this in plume directly.
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
the JSON object is passed from the Groovy script to the release script, we just need to extract the correct AWS Marketplace product ID based on the "<channel>-<arch>". Exception for the stable-amd64 where we also need to get the stable-pro product ID. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
When GCS auth is expected, plume would upload the AMI list to GCS.
This failed when used from ( secret_to_file ... VAR ; cat $VAR ) because ( ) starts a new subshell PID and secret_to_file's returned /proc/PID/fd/X path was then using the wrong PID.
We need to run plume only once for each arch, move it out of the loop. Also, address some smaller things that shellcheck complains about.
d007356
to
3fef1eb
Compare
tormath1
approved these changes
Sep 22, 2022
pothos
added a commit
that referenced
this pull request
Sep 22, 2022
ci-automation/release.sh: Run plume to release cloud images
pothos
added a commit
that referenced
this pull request
Sep 22, 2022
ci-automation/release.sh: Run plume to release cloud images
pothos
added a commit
that referenced
this pull request
Sep 22, 2022
ci-automation/release.sh: Run plume to release cloud images
pothos
added a commit
that referenced
this pull request
Sep 22, 2022
ci-automation/release.sh: Run plume to release cloud images
t-lo
added a commit
that referenced
this pull request
Oct 30, 2023
Temporary commit to use flatcar/mantle#475 for testing which ships the btrfs backwards compatibility test. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mantle plume tool has two steps, pre-release is the mere upload and release is the publication. In the past this was used to run the tests inbetween but we don't do this anymore.
Run plume pre-release and release in a single job. Since plume can't push to GCS in our case, we upload the files to bincache. Also do the cloudformation update which was previously done in flatcar-build-scripts but could only be run after the sync to Origin. It requires the "aws" tool in the mantle container until we implement this in plume directly.
Fixes flatcar/Flatcar#838
How to use
Add the
aws
tool to the mantle container. Add the new credentials to jenkins.Maybe we can cut a dummy Alpha release and test the pipeline with it? The git tag for the Alpha would have to use this branch.
→ Doing it for a trial
alpha-3367.0.0
Testing done
In http://jenkins.infra.kinvolk.io:8080/job/container/job/release/37/console
Closes: flatcar/Flatcar#739