Player Parser Refactor Pt1 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2022 19:51
Don't really know what this function does, but managed to separate it out from the main `run` function. This should be renamed once it's intent is clarified
|
That block of code mainly processes things that need to happen before the prompt shows again in midi shell mode as well as the shell itself. So that involves finishing pending commands and arpeggios, as well as allowing looping. Maybe I should go through and comment that more and we can figure out the best way to break it up. Maybe we could break it into 2 functions, process_pending() and show_prompt()? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning of refactoring player.py. It's not a very impressive refactor, we just pull a big try statement out and stick it in it's own function. This PR is WIP - if the refactor is correct, the function should still be given a more appropriate name, and we should add a doc string as well before merging. We could also continue to add more refactorings in this branch before merging if we'd prefer to not have a ton of PRs; just wanted to start small so its easy to review changes
Let me know what you think! Maybe you can enlighten me on what exactly we're doing here. Seems like it has something to do with when playback hits the end of the loop/file or something of that sort.