Should Identifiable be immutable?

[javier-godoy]

According to the javadoc, an Identifiable "represents an object that can be identified". There exist identifiable things that are immutable. The interface, however, has a setId method.

[mlopezFC]

Yes, good point.
For what I'm able to see, we're not using setId() anywhere, so we should be able to remove it without causing any harm.

[javier-godoy]

LGTM, let's do it.

[ngonzalezpazFC]

In the SIGAF project I am using setId given that they increment the id value manually in the code

[javier-godoy]

In the SIGAF project I am using setId given that they increment the id value manually in the code

I understand the project uses setId from BaseEntity, but not directly from Identifiable.

[ngonzalezpazFC]

In the SIGAF project I am using setId given that they increment the id value manually in the code

I understand the project uses setId from BaseEntity, but not directly from Identifiable.

Yes, you are right.