feat(js-client)!: Particle signatures [fixes DXJ-466] #353

akim-bow · 2023-09-28T15:02:24Z

No description provided.

linear · 2023-09-28T15:02:26Z

DXJ-466 Add support for signatures in js-client

Need to implement

Signature verification. Drop particle with missing or invalid signature.
Identify particles by their signature, not their id

packages/core/js-client/src/particle/Particle.ts

packages/core/js-client/src/util/bytes.ts

packages/core/js-client/src/connection/RelayConnection.ts

folex · 2023-09-28T21:57:54Z

packages/core/js-client/src/connection/RelayConnection.ts

+                                    log.trace('particle signature doesn\'t match with the message. rejecting particle with id: %s', particle.id);
                                }
+                            } catch (e) {
+                                log.error('error on handling a new incoming message: %j', e);


Suggested change

log.error('error on handling a new incoming message: %j', e);

log.error('error on handling an incoming particle: %j', e);

It would be very-very nice to print particle.id here. I guess that would require to try-catch Particle.from separately, but it surely worth it.

Being able to associate errors with particle.id is crucial.

Yeap, did it. Pls check again.

packages/core/js-client/src/keypair/__test__/KeyPair.spec.ts

packages/core/js-client/src/keypair/index.ts

packages/core/js-client/src/particle/Particle.ts

packages/core/js-client/src/clientPeer/__test__/client.spec.ts

packages/core/js-client/src/connection/RelayConnection.ts

packages/core/js-client/src/util/bytes.ts

packages/core/js-client/src/particle/Particle.ts

packages/core/js-client/src/compilerSupport/callFunction.ts

packages/core/js-client/src/connection/RelayConnection.ts

Co-authored-by: shamsartem <shamsartem@gmail.com>

justprosh

Maybe you disable signature verification for now and we first merge signature generation by js, then signature verification by nox, and finally merge signature verification by js-client

packages/core/js-client/src/jsPeer/FluencePeer.ts

packages/core/js-client/src/jsPeer/__test__/avm.spec.ts

packages/core/js-client/src/jsPeer/__test__/peer.spec.ts

shamsartem

From TS side everything looks good. Thanks!

packages/core/js-client/src/jsPeer/__test__/avm.spec.ts

packages/core/js-client/src/compilerSupport/callFunction.ts

folex · 2023-09-29T16:52:19Z

packages/core/js-client/src/jsServiceHost/interfaces.ts

     * Particle's signature
     */
-    signature?: string;
+    signature: Uint8Array;


Should be back to string in base64, right?

packages/core/js-client/src/keypair/index.ts

packages/core/js-client/src/connection/RelayConnection.ts

packages/core/js-client/src/particle/Particle.ts

packages/core/js-client/src/particle/interfaces.ts

Co-authored-by: folex <0xdxdy@gmail.com>

justprosh reviewed Sep 28, 2023

View reviewed changes

packages/core/js-client/src/particle/Particle.ts Outdated Show resolved Hide resolved

justprosh suggested changes Sep 28, 2023

View reviewed changes

packages/core/js-client/src/util/bytes.ts Show resolved Hide resolved

packages/core/js-client/src/connection/RelayConnection.ts Outdated Show resolved Hide resolved

folex reviewed Sep 28, 2023

View reviewed changes

packages/core/js-client/src/connection/RelayConnection.ts Show resolved Hide resolved

folex reviewed Sep 28, 2023

View reviewed changes

packages/core/js-client/src/connection/RelayConnection.ts Outdated Show resolved Hide resolved

folex reviewed Sep 28, 2023

View reviewed changes

packages/core/js-client/src/keypair/__test__/KeyPair.spec.ts Show resolved Hide resolved

folex reviewed Sep 28, 2023

View reviewed changes

packages/core/js-client/src/keypair/index.ts Show resolved Hide resolved

folex reviewed Sep 28, 2023

View reviewed changes

packages/core/js-client/src/particle/Particle.ts Outdated Show resolved Hide resolved

folex reviewed Sep 28, 2023

View reviewed changes

packages/core/js-client/src/particle/Particle.ts Show resolved Hide resolved

shamsartem reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/clientPeer/__test__/client.spec.ts Outdated Show resolved Hide resolved

shamsartem reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/connection/RelayConnection.ts Outdated Show resolved Hide resolved

shamsartem reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/connection/RelayConnection.ts Show resolved Hide resolved

Akim Mamedov added 7 commits September 29, 2023 16:37

Introduce particle signatures

34ca0d5

Fix particle id field in particle context

79a40c4

Fix types

6d2a4ed

Fix review comments

f5b5041

Remove init_peer_id from signature

cc4cc60

Fix typo

339feb8

Fix error msg

b43e96f

shamsartem reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/util/bytes.ts Outdated Show resolved Hide resolved

shamsartem reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/particle/Particle.ts Outdated Show resolved Hide resolved

shamsartem reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/particle/Particle.ts Show resolved Hide resolved

Akim Mamedov added 2 commits September 29, 2023 17:52

Fix async promise constructor antipattern

0ccbab5

Refactor utils

81136bf

shamsartem reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/compilerSupport/callFunction.ts Outdated Show resolved Hide resolved

Move text encoder outside

307842b

shamsartem reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/connection/RelayConnection.ts Outdated Show resolved Hide resolved

Akim Mamedov and others added 2 commits September 29, 2023 18:50

Use async/await

3d8e423

Update packages/core/js-client/src/connection/RelayConnection.ts

18cd294

Co-authored-by: shamsartem <shamsartem@gmail.com>

justprosh approved these changes Sep 29, 2023

View reviewed changes

shamsartem reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/jsPeer/FluencePeer.ts Outdated Show resolved Hide resolved

shamsartem reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/jsPeer/__test__/avm.spec.ts Outdated Show resolved Hide resolved

shamsartem reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/jsPeer/__test__/peer.spec.ts Show resolved Hide resolved

Akim Mamedov added 6 commits September 29, 2023 22:36

Hide crypto implementation beside KeyPair

27b9fa5

Fix verify method

0e589d1

Comment verify method

6a472c6

Use particle signature instead of id

8ffd773

remove async/await from method

a62c3a3

Fix type

11c736a

shamsartem approved these changes Sep 29, 2023

View reviewed changes

folex reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/jsPeer/__test__/avm.spec.ts Show resolved Hide resolved

folex changed the title ~~feat(js-client): Particle signatures [fixes DXJ-466]~~ feat(js-client)!: Particle signatures [fixes DXJ-466] Sep 29, 2023

folex reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/compilerSupport/callFunction.ts Show resolved Hide resolved

folex reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/keypair/index.ts Show resolved Hide resolved

folex reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/keypair/index.ts Outdated Show resolved Hide resolved

folex reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/connection/RelayConnection.ts Outdated Show resolved Hide resolved

folex reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/particle/Particle.ts Outdated Show resolved Hide resolved

folex reviewed Sep 29, 2023

View reviewed changes

packages/core/js-client/src/particle/interfaces.ts Outdated Show resolved Hide resolved

Akim and others added 6 commits September 30, 2023 02:50

Update packages/core/js-client/src/particle/interfaces.ts

22cfc8c

Co-authored-by: folex <0xdxdy@gmail.com>

Update packages/core/js-client/src/particle/Particle.ts

03f0311

Co-authored-by: folex <0xdxdy@gmail.com>

Fix review comment

54b8e62

Update pipe

018d3c2

set logging

10d00ca

try cache

8b2e1fe

fluencebot mentioned this pull request Oct 2, 2023

chore: release master #354

Merged

	log.error('error on handling a new incoming message: %j', e);
	log.error('error on handling an incoming particle: %j', e);

feat(js-client)!: Particle signatures [fixes DXJ-466] #353

feat(js-client)!: Particle signatures [fixes DXJ-466] #353

Uh oh!

Conversation

akim-bow commented Sep 28, 2023

Uh oh!

linear bot commented Sep 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

folex Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

folex Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

akim-bow Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

justprosh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shamsartem left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

folex Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

akim-bow Oct 2, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants