This repository was archived by the owner on Jul 10, 2025. It is now read-only.
fix(js-client): Fix CDN flow and move it in modules [fixes DXJ-527] #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsartem
reviewed
Nov 10, 2023
| "/ip4/127.0.0.1/tcp/9991/ws/p2p/12D3KooWBM3SdXWqGaawQDGQ6JprtwswEg3FWGvGhmgmMez1vRbR", | ||
| peerId: "12D3KooWBM3SdXWqGaawQDGQ6JprtwswEg3FWGvGhmgmMez1vRbR", | ||
| }; | ||
| const relay = randomStage(); |
There was a problem hiding this comment.
why stage? tests should run on the local network
There was a problem hiding this comment.
Thanks, you're right.
shamsartem
reviewed
Nov 10, 2023
Co-authored-by: shamsartem <shamsartem@gmail.com>
shamsartem
reviewed
Nov 10, 2023
.github/workflows/tests.yml
Outdated
| description: "nox image tag" | ||
| type: string | ||
| default: "fluencelabs/nox:minimal_0.2.9" | ||
| default: "fluencelabs/nox:minimal_0.4.0" |
There was a problem hiding this comment.
I know that soon minimal_ prefixes will be gone. Please try without it
added 3 commits
November 10, 2023 20:36
shamsartem
approved these changes
Nov 10, 2023
added 3 commits
November 10, 2023 21:04
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.