Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure assertions with nested classes instead of regions (Part 5) #1909

Conversation

IT-VBFK
Copy link
Contributor

@IT-VBFK IT-VBFK commented Apr 23, 2022

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

@coveralls
Copy link

coveralls commented Apr 23, 2022

Pull Request Test Coverage Report for Build 2213230295

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.607%

Totals Coverage Status
Change from base Build 2212333659: 0.0%
Covered Lines: 8502
Relevant Lines: 8769

💛 - Coveralls

jnyrup
jnyrup approved these changes Apr 23, 2022
Copy link
Member

@jnyrup jnyrup left a comment

I really wish github would support selecting diff algorithm.
Checking out the branch and running this made review a 2 minute task.
git diff -wU0 --diff-algorithm=histogram develop

@IT-VBFK
Copy link
Contributor Author

IT-VBFK commented Apr 24, 2022

As far as I have seen.. this PR is one of the last ones anyway :)

@IT-VBFK
Copy link
Contributor Author

IT-VBFK commented Apr 24, 2022

Ahhm.. small question: Should I move the tests from Tests/Fluentasserion.Specs/Collections/CollectionAssertionSpecs.cs to the appropriate files too?

@dennisdoomen dennisdoomen merged commit fb4edca into fluentassertions:develop Apr 24, 2022
1 check passed
@IT-VBFK IT-VBFK deleted the structure-assertions-with-nested-classes-instead-of-regions-5 branch Apr 24, 2022
@jnyrup
Copy link
Member

jnyrup commented Apr 24, 2022

Ahhm.. small question: Should I move the tests from Tests/Fluentasserion.Specs/Collections/CollectionAssertionSpecs.cs to the appropriate files too?

Sure, go ahead.

@IT-VBFK
Copy link
Contributor Author

IT-VBFK commented Apr 24, 2022

Cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants