Fix bug where you could trigger simultaneous connects by accidentally clicking or pressing return twice #3114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
commented
Jun 11, 2021
| 'The "$page" screen is not available for this application.'), | ||
| page != null | ||
| ? 'The "$page" screen is not available for this application.' | ||
| : 'No tabs available for this application.', |
There was a problem hiding this comment.
This should now never occur but the previous message was confusing.
jacob314
commented
Jun 11, 2021
| @@ -117,7 +117,7 @@ class _InitializerState extends State<Initializer> | |||
|
|
|||
| /// Shows a "disconnected" overlay if the [service.serviceManager] is not currently connected. | |||
| void _handleNoConnection() { | |||
| WidgetsBinding.instance.addPostFrameCallback((_) { | |||
| WidgetsBinding.instance.scheduleFrameCallback((_) { | |||
There was a problem hiding this comment.
I don't understand why we were using a postFrameCallback. A frame might not render and then it wouldn't be called till some strange later time.
| @@ -1305,3 +1281,18 @@ extension BoolExtension on bool { | |||
| return -1; | |||
| } | |||
| } | |||
|
|
|||
| Future<T> whenValueNonNull<T>(ValueListenable<T> listenable) { | |||
There was a problem hiding this comment.
I don't see where this is used in this PR?
There was a problem hiding this comment.
it is used in a future pr.
| if (value != null) { | ||
| completer.complete(value); | ||
| } | ||
| listenable.removeListener(listener); |
There was a problem hiding this comment.
what if value is null? Then we would remove the listener and the completer would never complete. If value is null, should we keep listening?
There was a problem hiding this comment.
agreed. Fixed the logic.
kenzieschmoll
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach of delaying by 250ms was insufficient. This matches other UI in DevTools where we block actions while the current action is in progress.