Add "prefersDebugSession" + rename capabilities flag #7949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
approved these changes
Jun 20, 2024
|
@kenzieschmoll I've published an updated pre-release of Dart-Code (3.91.20240620) that includes the Dart-Code side of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new flag
prefersDebugSessionsimilar to the one added yesterdayrequiresDebugSessionto better handle tools that should have debug sessions if they exist but can also be launched without.Since the change landed yesterday has not shipped, I renamed the capabilities flag to cover both options.
The editor behaviour I have implemented currently (but am happy to tweak is) that if this is flag is true then:
We could just use the "active debug session" (according to VS Code) for the last one, but since we don't do that for other things yet (we always prompt) and we're not showing the "active" debug session in the sidebar yet, I think prompting makes most sense. In most cases, probably users don't have multiple debug sessions anyway.
@kenzieschmoll I will push a new Dart-Code pre-release with those changes once this merges. I don't want to do it now in case there is feedback or you're still working against the already-merged code (since the capability flag is renamed).