Skip to content

Conversation

elliette
Copy link
Member

@elliette elliette commented Apr 3, 2025

Note: The slightly odd alignment of the "Docs" text is also an issue for the normal DevTools footer. Filed #9098 (will fix if I have time, but trying to get in a few other changes before the cut off!)

Documentation hasn't been written yet, but I will add it to the Flutter site before the stable release.

Screenshot 2025-04-03 at 3 15 21 PM

@elliette elliette requested a review from a team as a code owner April 3, 2025 22:18
@elliette elliette requested review from kenzieschmoll and removed request for a team April 3, 2025 22:18
],
),
),
const _PropertyEditorFooter(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use the existing StatusLine widget or at least its sub components?

Copy link
Member Author

@elliette elliette Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the StatusLine and its components expect there to be a Screen, which doesn't exist for the Property Editor or other side panels - I think there would be some refactoring necessary to make that work but could do as a follow-up!

The side panel "screens" are actually widgets and not Screens:

class _DtdConnectedScreen extends StatelessWidget {

Copy link
Member

@kenzieschmoll kenzieschmoll Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg to clean up later. At the very least we could make the DocumentationLink widget more general and not depend on a screen

Comment on lines +192 to +194
const uriPrefix = 'https://docs.flutter.dev/tools/';
const uriHash = '#property-editor';
return '$uriPrefix${queryParams.ide == 'VSCode' ? 'vs-code' : 'android-studio'}$uriHash';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should verify with the docs maintainers that there is a way to ensure we don't have to duplicate the content even if it is documented at two different locations.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if nothing else I was planning on having these sections link to a shared Property Editor section

@elliette elliette merged commit d2d7962 into flutter:master Apr 4, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants