-
Notifications
You must be signed in to change notification settings - Fork 359
[Property Editor] Add a footer for opening documentation / reporting errors #9099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
], | ||
), | ||
), | ||
const _PropertyEditorFooter(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use the existing StatusLine
widget or at least its sub components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the StatusLine
and its components expect there to be a Screen
, which doesn't exist for the Property Editor or other side panels - I think there would be some refactoring necessary to make that work but could do as a follow-up!
The side panel "screens" are actually widgets and not Screens
:
class _DtdConnectedScreen extends StatelessWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sg to clean up later. At the very least we could make the DocumentationLink widget more general and not depend on a screen
const uriPrefix = 'https://docs.flutter.dev/tools/'; | ||
const uriHash = '#property-editor'; | ||
return '$uriPrefix${queryParams.ide == 'VSCode' ? 'vs-code' : 'android-studio'}$uriHash'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should verify with the docs maintainers that there is a way to ensure we don't have to duplicate the content even if it is documented at two different locations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if nothing else I was planning on having these sections link to a shared Property Editor section
Note: The slightly odd alignment of the "Docs" text is also an issue for the normal DevTools footer. Filed #9098 (will fix if I have time, but trying to get in a few other changes before the cut off!)
Documentation hasn't been written yet, but I will add it to the Flutter site before the stable release.