This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Firebase test for Platform Views on iOS #11350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
requested review from
cbracken,
collinjackson,
jmagman,
amirh and
digiter
cbracken
approved these changes
Aug 21, 2019
| --results-dir=engine_scenario_test/$GIT_REVISION/$BUILD_ID \ | ||
|
|
||
|
|
||
| popd |
There was a problem hiding this comment.
nit: pushds and popds don't balance. Is that intentional?
jmagman
reviewed
Aug 21, 2019
| if (golden) { | ||
| XCTAttachment* goldenAttachment = [XCTAttachment attachmentWithImage:golden]; | ||
| goldenAttachment.lifetime = XCTAttachmentLifetimeKeepAlways; | ||
| [self addAttachment:goldenAttachment]; | ||
| } else { | ||
| NSLog(@"This test will fail - no golden named %@ found. Follow the steps in the README to add " |
There was a problem hiding this comment.
I want it to continue so it will generate the potentially good screenshot for you
There was a problem hiding this comment.
I guess I could generate the good screen shot, attach it, and fail though - which would fail slighty faster than I currently am. WDYT?
There was a problem hiding this comment.
It would be better for the test failure to suggest what to do than have to dig through logs.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2019
This was referenced Aug 21, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 21, 2019
git@github.com:flutter/engine.git/compare/ab097a59faf5...1efb5b7 git log ab097a5..1efb5b7 --no-merges --oneline 2019-08-21 dnfield@google.com update sim script (flutter/engine#11355) 2019-08-21 dnfield@google.com Firebase test for Platform Views on iOS (flutter/engine#11350) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this can land, I'll update the recipe to run this in addition to the simulator tests.
Then I think I'm good to land #11070