iOS platform view mutation XCUITests #11652

cyanglaz · 2019-08-28T21:26:19Z

Added scenarios for all the available mutations on iOS platform view. Including: clipRect, clipRRect, clipPath, transform, opacity
Added screenshot tests for each scenarios that added.
for each test(including the existing test), added code to wait until the platform view is visible on the screen.
Added golden for simulator iphone se
ClippingView was previously size (0, 0). The XCUITest ignore the ClippingView because of this. Updated the ClippingView to the same size as flutterView so it can be found by the XCUITest.
Factored the platform_view.dart so it is easier to add a new platform related scenario
Factored some util methods out of PlatformViewUITests.m so it is easier to add new platform view related UITests

@dnfield let me know if you prefer smaller patches.

All the platform view mutation updates will be unblocked after landing this.

dnfield · 2019-08-28T22:25:49Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewUITestUtil.m

+#import "PlatformViewUITestUtil.h"
+#include <sys/sysctl.h>
+
+const NSInteger kTimeToWaitForPlatformView = 5;


Let's make this higher. Particularly on a simulator on a bogged down CI machine this might be slow. There's no harm in giving it 30 seconds before we fail the whole test.

We should also have a comment here explaining that this is in seconds.

dnfield · 2019-08-28T22:30:29Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewMutationTests.m

+    XCTFail(@"It took longer than %@ second to find the platform view."
+            @"There might be issues with the platform view's construction,"
+            @"or with how the scenario is built.",
+            @(kTimeToWaitForPlatformView));


nit: can this just be moved to setUp after launching?

Well, all of these similar ones to either setUp or some utility/super method to avoid the repetition

Asserting in -setUp can have weird test failures, the details of which are slipping my mine at the moment (it says some test failed but doesn't say which?). However refactoring out into a method that's used at the top of each test would work (assuming the bigger subclass refactor I suggest doesn't get done).

dnfield · 2019-08-28T22:32:09Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewMutationTests.m

+  XCTAssertTrue([PlatformViewUITestUtil compareImage:golden toOther:screenshot.image]);
+}
+
+@end


For pretty much all of these - maybe just one method that wrapps all the common behavior and takes in the expected golden file name?

dnfield · 2019-08-28T22:33:50Z

testing/scenario_app/lib/src/platform_view.dart

+
+    final PictureRecorder recorder = PictureRecorder();
+    final Canvas canvas = Canvas(recorder);
+    canvas.drawCircle(const Offset(50, 50), 50, Paint()..color = const Color(0xFFABCDEF));


Can we do something like this in the base case? It seemed valuable to me to make sure that Flutter drawn UI would still show up with or over a platform view.

dnfield · 2019-08-28T22:34:11Z

testing/scenario_app/lib/src/platform_view.dart

+    final SceneBuilder builder = SceneBuilder();
+
+    builder.pushOffset(0, 0);
+    builder.pushClipRRect(RRect.fromLTRBAndCorners(50, 50, 300, 300, topLeft:Radius.circular(15), topRight:Radius.circular(50), bottomLeft:Radius.circular(50)));


nit - add some trailing commas and split up this long line

dnfield · 2019-08-28T22:34:34Z

testing/scenario_app/lib/src/platform_view.dart

+
+    builder.pushOffset(0, 0);
+    Path path = Path();
+    path.moveTo(200, 0);


nit - add a comment explaining what shape you're expecting to build here.

dnfield · 2019-08-28T22:35:25Z

testing/scenario_app/lib/src/platform_view.dart

+    matrix4[15] = 1.0;
+
+
+    // rotate for 1 degree radians


I'm pretty sure this should just be rotate 1 radian.

It also might be worht just using Matrix4 here and taking a dependency on vector_math, but probably not a big deal either way.

dnfield · 2019-08-28T22:35:49Z

testing/scenario_app/lib/src/platform_view.dart

  }
-}
+}


new line at EOF

dnfield

Over all looks good, mostly just nits.

dnfield · 2019-08-28T22:36:48Z

@jmagman might have some good tips about structuring the Unit tests and generally reviewing the Objective C :)

jmagman · 2019-08-28T22:40:53Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewMutationTests.m

+// found in the LICENSE file.
+
+#import <XCTest/XCTest.h>
+#import "../Scenarios/TextPlatformView.h"


I would expect to not need a relative path:
#import "TextPlatformView.h"

jmagman · 2019-08-28T22:42:48Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewMutationTests.m

+    XCTFail(@"It took longer than %@ second to find the platform view."
+            @"There might be issues with the platform view's construction,"
+            @"or with how the scenario is built.",
+            @(kTimeToWaitForPlatformView));


Asserting in -setUp can have weird test failures, the details of which are slipping my mine at the moment (it says some test failed but doesn't say which?). However refactoring out into a method that's used at the top of each test would work (assuming the bigger subclass refactor I suggest doesn't get done).

jmagman · 2019-08-28T23:09:55Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewMutationTests.m

+  NSBundle* bundle = [NSBundle bundleForClass:[self class]];
+  NSString* goldenName = [NSString
+      stringWithFormat:@"golden_platform_view_cliprect_%@", [PlatformViewUITestUtil platformName]];
+  NSString* path = [bundle pathForResource:goldenName ofType:@"png"];


Prefer NSURL APIs over NSString path ones. I realized you copied this from @dnfield's code, but I missed it in that code review! Unfortunately there isn't a +[UIImage imageWithData:] API so it adds a local.

NSURL* goldenURL = [bundle URLForResource:goldenName withExtension:@"png"]; NSData* goldenData = [NSData dataWithContentsOfURL:goldenURL] UIImage* golden = [[UIImage alloc] initWithData:goldenData];

jmagman · 2019-08-28T23:29:31Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewMutationTests.m

+// Clip Rect Tests
+@interface PlatformViewMutationClipRectTests : XCTestCase
+
+@property(nonatomic, strong) XCUIApplication* application;


Can this file be DRY'd out? It looks like a lot of boilerplate.
Maybe something like this? I wrote this up but didn't try to compile, so check it first.

@interface GoldenPlatformViewTests : XCTestCase - (instancetype)initWithLaunchArguments:(NSString*)platformViewLaunchArguments goldenName:(NSString*)goldenName NS_DESIGNATED_INITIALIZER; - (instancetype)init NS_UNAVAILABLE; @end @interface GoldenPlatformViewTests () @property (copy) NSString* platformViewLaunchArguments; @property (copy) NSString* goldenName; @end @implementation GoldenPlatformViewTests - (instancetype)initWithLaunchArguments:(NSString*)platformViewLaunchArguments goldenName:(NSString*)goldenName { self = [super init]; _platformViewLaunchArguments = platformViewLaunchArguments; _goldenName = goldenName; return self; } - (void)setUp { [super setUp]; self.continueAfterFailure = NO; self.application = [[XCUIApplication alloc] init]; self.application.launchArguments = @[ self.platformViewLaunchArguments ]; [self.application launch]; } // Note: don't prefix with "test" or GoldenPlatformViewTests will run instead of the subclasses. - (void)checkGolden { XCUIElement* element = self.application.textViews.firstMatch; BOOL exists = [element waitForExistenceWithTimeout:kTimeToWaitForPlatformView]; if (!exists) { ... } } @end

@interface PlatformViewMutationClipRRectTests : GoldenPlatformViewTests - (instancetype)init NS_DESIGNATED_INITIALIZER; - (instancetype)initWithLaunchArguments:(NSString*)platformViewLaunchArguments goldenName:(NSString*)goldenName NS_UNAVAILABLE; @end @implementation PlatformViewMutationClipRectTests - (instancetype)init { NSString* goldenName = [NSString stringWithFormat:@"golden_platform_view_cliprect_%@", [PlatformViewUITestUtil platformName]]; return [super initWithLaunchArguments:@"--platform-view-cliprect" goldenName:goldenName]; } @end - (void)testPlatformView { [self checkGolden]; }

jmagman · 2019-08-28T23:30:51Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewUITestUtil.h

+
+@interface PlatformViewUITestUtil : NSObject
+
+ (NSString*)platformName;


This should be a class property.

@property (class, copy, readonly) NSString* platformName;

jmagman · 2019-08-28T23:34:35Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewUITestUtil.h

+
+extern const NSInteger kTimeToWaitForPlatformView;
+
+@interface PlatformViewUITestUtil : NSObject


Instead of this utility class, can you make a GoldenImage class with a UIImage property, then implement -isEqual: and -hash?
Then you can initialize it with a name prefix, and it can have a goldenName property that uses the hardware logic, and even figure out the launch args.
If you do that, then my above suggested GoldenPlatformViewTests initializer could become:

- (instancetype)initWithGoldenImage:(GoldenImage*)goldenImage;

cyanglaz · 2019-08-29T20:20:53Z

Updated the PR!

@dnfield
I ended up mostly followed with @jmagman's suggestion on the objc side.
On the dart side, I updated with your suggestion and also added a little drawing to show what would the clip path look like :). Also added Matrix4 deps for transform. And refactored more code in onBeginFrame into the parent class including adding a picture on top of the platform view

@jmagman
I improvised a bit and created a PlatformViewGoldenTestManager along with the GoldenImage class.
GoldenImage handles things related to golden, such as getting a UIImage from golden name, construct the golden name, and compare the golden image to a UIImage(screenshot).
PlatformViewGoldenTestManager contains a map mapping an id with the run arguments. So it chose what run args to use when initialized with an id. It also creates a GoldenImage based on the id., which the id is used as the prefix of the goldenImageName.

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewGoldenTestManager.m

dnfield · 2019-08-29T20:48:34Z

testing/scenario_app/lib/src/platform_view.dart

+    // The left side of the rectangle becomes a symmetric curve towards the left.
+    // The right side of the rectangle becomes a double curve. From top of bottom of the curve, it goes left then right.
+    //     _______
+    //    |      |


Nit: Maybe just a reference to the golden image for this, or a link to it on github instead of the ASCII art.

dnfield · 2019-08-29T20:49:19Z

testing/scenario_app/lib/src/platform_view.dart

+
+    builder.pushOffset(0, 0);
+    final Matrix4 matrix4 = Matrix4.identity();
+    matrix4.rotateZ(1.0);


Nit:

final Matrix4 matrix4 = Matrix4.identity() ..rotateZ(1.0) ..scale(0.5, 0.5, 1.0) ..translate(1000.0, 100.0, 0.0);

dnfield · 2019-08-29T20:49:46Z

testing/scenario_app/lib/src/platform_view.dart

+    matrix4.scale(0.5, 0.5, 1.0);
+    matrix4.translate(1000.0, 100.0, 0.0);
+
+    final Float64List matrix4_64 =  Float64List.fromList(matrix4.storage);


You don't need the copy here - just do builder.pushTransform(matrix4.storage)

matrix4.storage is a Float32List, builder.pushTransform(matrix4.storage) throws a compile error.

Ahh - make sure you import vector_math_64.dart :)

dnfield · 2019-08-29T20:50:51Z

testing/scenario_app/lib/src/platform_view.dart

    const int _valueInt32 = 3;
    const int _valueFloat64 = 6;
    const int _valueString = 7;
    const int _valueUint8List = 8;
    const int _valueMap = 13;
    final Uint8List message = Uint8List.fromList(<int>[
      _valueString,
-      'create'.length, // this is safe as long as these are all single byte characters.
+      'create'
+          .length, // this is safe as long as these are all single byte characters.


Please move this back up to line 186 - it's ok if the comment goes over 80. Maybe just ditch the comment, or rephrase as // this won't work if we use multibyte characters

dnfield · 2019-08-29T20:51:38Z

testing/scenario_app/pubspec.yaml

@@ -8,3 +8,4 @@ dependencies:
   path: ../../../out/host_debug_unopt/gen/dart-pkg/sky_engine
 sky_services:
   path: ../../../out/host_debug_unopt/gen/dart-pkg/sky_services
+ vector_math: any


Please use a specific version for vector_math, e.g. ^2.0.8

dnfield · 2019-08-29T20:52:23Z

Looking better! A few comments on the Dart side, I'll defer to @jmagman to finish out the ObjC review but it looks better overall.

dnfield · 2019-08-29T20:57:22Z

testing/scenario_app/lib/src/platform_view.dart

@@ -6,6 +6,7 @@ import 'dart:convert';
 import 'dart:io';
 import 'dart:typed_data';
 import 'dart:ui';
+import 'package:vector_math/vector_math.dart';


you want import 'package:vector_math/vector_math_64.dart';

jmagman · 2019-08-29T20:30:04Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/GoldenImage.h

+
+@interface GoldenImage : NSObject
+
+@property(readonly, strong, nonatomic) NSString* goldenName;


jmagman · 2019-08-29T20:53:57Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/GoldenImage.h

+// Compare this GoldenImage to `image`.
+//
+// Return YES if the `image` of this GoldenImage have the same pixels of provided `image`.
+- (BOOL)compareGoldenToImage:(nonnull UIImage*)image;


Remove nonnull, you are in a NS_ASSUME_NONNULL_BEGIN. You only need to mark nullables.

jmagman · 2019-08-29T20:54:33Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/GoldenImage.m

+
+@interface GoldenImage ()
+
+@property(readwrite, strong, nonatomic) NSString* goldenName;


Remove all these read-write properties, you are setting their backing instance variable in the init so the setters aren't called anywhere.

jmagman · 2019-08-29T20:55:42Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/GoldenImage.m

+
+@property(readwrite, strong, nonatomic) NSString* goldenName;
+@property(readwrite, strong, nonatomic) UIImage* image;
+@property(strong, nonatomic) NSString* platformName;


Remove this property, you don't need the backing instance variable since you only use it one time in init to create _goldenName.
You can make it a NS_INLINE function:

NS_INLINE NSString* _platformName() { NSString* simulatorName = [[NSProcessInfo processInfo].environment objectForKey:@"SIMULATOR_DEVICE_NAME"]; if (simulatorName) { return [NSString stringWithFormat:@"%@_simulator", simulatorName]; } size_t size; sysctlbyname("hw.model", NULL, &size, NULL, 0); char* answer = malloc(size); sysctlbyname("hw.model", answer, &size, NULL, 0); NSString* results = [NSString stringWithCString:answer encoding:NSUTF8StringEncoding]; free(answer); return results; }

jmagman · 2019-08-29T21:09:10Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/GoldenImage.m

+  return self;
+}
+
+- (BOOL)compareGoldenToImage:(UIImage*)image {


Override -isEqual: and -hash instead.

Override -isEqual: and -hash instead.

Oh actually never mind, that would require you to make a GoldenImage out of the screen shot. This is fine.

jmagman · 2019-08-29T21:24:44Z

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewGoldenTestManager.m

+
+static NSDictionary* _launchArgsMap;
+
+ (void)initialize {


Overriding +initialize is very frowned upon. You can make the static dictionary a local variable in -initWithIdentifier. Or create the tested golden out of the launch args. Or make it an extern somewhere to be used by AppDelegate as @dnfield suggests.

Or make it an extern somewhere to be used by AppDelegate as @dnfield suggests.

@cyanglaz correctly points out this isn't possible in a XCUITest.

dnfield · 2019-08-29T22:15:59Z

testing/scenario_app/lib/src/platform_view.dart

+
+    builder.pushOffset(0, 0);
+    final Matrix4 matrix4 = Matrix4.identity()
+    ..rotateZ(1.0)


nit agian: indent these :)

dnfield

Dart code and overall approach LGTM. Will defer to @jmagman for rest of ObjC review

cyanglaz · 2019-08-30T00:13:53Z

@jmagman

Updated the objc code. I think it is ready for another review.

I ended up adding duplicate maps in AppDelegate and PlatformViewGoldenTestManager.

jmagman

LGTM with nits about the static dictionary, fast enumeration, and auditing for generics.
Thank you for making all these changes, it looks good!

jmagman · 2019-09-13T18:16:16Z

testing/scenario_app/ios/Scenarios/Scenarios/AppDelegate.m

+    };
+  });
+  BOOL hasGoldenLaunchArg = NO;
+  for (NSString* key in launchArgsMap.allKeys) {


Use fast-enumeration for iterating dictionaries instead of allocating a new array and then doing a value lookup later.

__block BOOL hasGoldenLaunchArg = NO; [launchArgsMap enumerateKeysAndObjectsUsingBlock:^(NSString* argument, NSString* testName, BOOL *stop) { if ([[[NSProcessInfo processInfo] arguments] containsObject:argument]) { [self readyContextForPlatformViewTests:testName]; hasGoldenLaunchArg = YES; *stop = YES; } }];

jmagman · 2019-09-13T18:16:41Z

testing/scenario_app/ios/Scenarios/Scenarios/AppDelegate.m

-    self.window.rootViewController = flutterViewController;
-  } else {
+  // The launchArgsMap should match the one in the `PlatformVieGoldenTestManager`.
+  static NSDictionary* launchArgsMap;


application:didFinishLaunchingWithOptions: will only be called once, so you don't need the overhead of the static and dispatch_once.
Also, always use generics.

NSDictionary<NSString*, NSString*>* launchArgsMap;

…lutter#11652)" This reverts commit b73cfda.

…11652)" (#12292) This reverts commit b73cfda.

…lutter/engine#11652)

git@github.com:flutter/engine.git/compare/834cd15010b2...31e5149 git log 834cd15..31e5149 --no-merges --oneline 2019-09-16 iska.kaushik@gmail.com Revert "Revert "Roll src/third_party/dart a554c8be6b..d0052c1b31 (22 commits)" (#12290)" (flutter/engine#12291) 2019-09-16 iska.kaushik@gmail.com Revert "Add iOS platform view mutation XCUITests to the scenario app (#11652)" (flutter/engine#12292) 2019-09-15 ychris@google.com Add iOS platform view mutation XCUITests to the scenario app (flutter/engine#11652) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

git@github.com:flutter/engine.git/compare/834cd15010b2...31e5149 git log 834cd15..31e5149 --no-merges --oneline 2019-09-16 iska.kaushik@gmail.com Revert "Revert "Roll src/third_party/dart a554c8be6b..d0052c1b31 (22 commits)" (flutter#12290)" (flutter/engine#12291) 2019-09-16 iska.kaushik@gmail.com Revert "Add iOS platform view mutation XCUITests to the scenario app (flutter#11652)" (flutter/engine#12292) 2019-09-15 ychris@google.com Add iOS platform view mutation XCUITests to the scenario app (flutter/engine#11652) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

…lutter#11652))

…11652)" (#12707)

Chris Yang added 4 commits August 27, 2019 15:30

wait for platform view appear

7418e7e

add uitest for all the available mutations

4d13348

remove uncessary code

4edf7cd

remove unnecssary golden

df45e14

cyanglaz requested a review from dnfield August 28, 2019 21:26

googlebot added the cla: yes label Aug 28, 2019

formatting

97f736a

dnfield reviewed Aug 28, 2019

View reviewed changes

testing/scenario_app/lib/src/platform_view.dart Outdated

}

}

}

Copy link

Contributor

dnfield Aug 28, 2019 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line at EOF

dnfield reviewed Aug 28, 2019

View reviewed changes

dnfield requested a review from jmagman August 28, 2019 22:36

jmagman suggested changes Aug 28, 2019

View reviewed changes

review fixes

5be3a9e

formatting

a2dafee

dnfield reviewed Aug 29, 2019

View reviewed changes

testing/scenario_app/ios/Scenarios/ScenariosUITests/PlatformViewGoldenTestManager.m Outdated Show resolved Hide resolved

dnfield reviewed Aug 29, 2019

View reviewed changes

review fixes(dart)

4ed4a6c

jmagman suggested changes Aug 29, 2019

View reviewed changes

dnfield reviewed Aug 29, 2019

View reviewed changes

dnfield approved these changes Aug 29, 2019

View reviewed changes

review fixes

285ffc2

jmagman approved these changes Sep 13, 2019

View reviewed changes

Chris Yang added 2 commits September 14, 2019 22:56

review fixes

b4dbcc0

merge master

f8c2a8e

cyanglaz merged commit b73cfda into flutter:master Sep 15, 2019

cyanglaz deleted the ios_platform_view_mutation_uitest branch September 15, 2019 23:56

iskakaushik pushed a commit to iskakaushik/engine that referenced this pull request Sep 16, 2019

Revert "Add iOS platform view mutation XCUITests to the scenario app (f…

c9e6ce0

…lutter#11652)" This reverts commit b73cfda.

iskakaushik mentioned this pull request Sep 16, 2019

Revert "Add iOS platform view mutation XCUITests to the scenario app … #12292

Merged

iskakaushik added a commit that referenced this pull request Sep 16, 2019

Revert "Add iOS platform view mutation XCUITests to the scenario app (#…

289d1ea

…11652)" (#12292) This reverts commit b73cfda.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 16, 2019

b73cfda Add iOS platform view mutation XCUITests to the scenario app (f…

6a1fcf3

…lutter/engine#11652)

engine-flutter-autoroll mentioned this pull request Sep 16, 2019

Roll engine 834cd15010b2..31e5149a805b (3 commits) flutter/flutter#40549

Merged

cyanglaz restored the ios_platform_view_mutation_uitest branch September 23, 2019 02:00

cyanglaz pushed a commit to cyanglaz/engine that referenced this pull request Sep 30, 2019

reland Add iOS platform view mutation XCUITests to the scenario app((f…

b0ae3eb

…lutter#11652))

cyanglaz mentioned this pull request Sep 30, 2019

Reland "Add iOS platform view mutation XCUITests to the scenario app(#11652)" #12707

Merged

cyanglaz pushed a commit that referenced this pull request Oct 1, 2019

Reland "Add iOS platform view mutation XCUITests to the scenario app(#…

bf620dc

…11652)" (#12707)


		@interface PlatformViewUITestUtil : NSObject

		+ (NSString*)platformName;


		extern const NSInteger kTimeToWaitForPlatformView;

		@interface PlatformViewUITestUtil : NSObject


		@interface GoldenImage : NSObject

		@property(readonly, strong, nonatomic) NSString* goldenName;


		@interface GoldenImage ()

		@property(readwrite, strong, nonatomic) NSString* goldenName;

iOS platform view mutation XCUITests #11652

iOS platform view mutation XCUITests #11652

Uh oh!

Conversation

cyanglaz commented Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmagman Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnfield Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

dnfield commented Aug 28, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmagman Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmagman Aug 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cyanglaz commented Aug 29, 2019

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnfield commented Aug 29, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

cyanglaz commented Aug 28, 2019 •

edited

Loading

jmagman Aug 28, 2019 •

edited

Loading

dnfield Aug 28, 2019 •

edited

Loading

jmagman Aug 28, 2019 •

edited

Loading

jmagman Aug 28, 2019 •

edited

Loading

jmagman Aug 29, 2019 •

edited

Loading