Roll dart to e6887536aadc7fbd1990448989601cee0224958d. #12235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes since last roll: ``` e688753 [ VM ] Ignore contexts which have been optimized out during stack overflow checks dabfda5 Revert "[vm/compiler] Check def/use relation for PushArguments in environment." 596a4ab [vm/bytecode] No need to set breakpoints in bytecode if interpreter is not used. 531cb02 Fix language_2/mixin_constructor_forwarding/* tests. 24f45d6 Delete language_2/generic_no_such_method_dispatcher_simple_test. 0c481a1 Revert Reland '[vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs).' as it breaks flutter profile execution on ios 32-bit platform. 1d01d91 fix for sort_child_properties_last 586869c [vm/bytecode] Fix iteration of bytecode local variables eac977b Issue 38273. Fix for inlining methods ending with a return statement without an expression. 0d1636e Simplify how the list of TestCases for each TestConfiguration is made. c8e389f [vm/fuzzer] List versions for each git commit c6b0ae1 Fix for indexing FieldFormalParameterMember with unresolved field. d18bfb4 Fix language_2/super_call4_test. c464a12 Minimize diffs between copies of js_dart2js.dart c99cd5b Add more dart:html, enough for angular_analyzer_plugin. 3e63f06 Remove CancelableFuture. 315e9c1 [gardening] Avoid --deterministic in regress_merge_blocks_with_phis_test 25edeb7 Support completing the extension name locally e8836f5 Fix sample for UNDEFINED_SETTER. 971b519 Apply missed changes to NNBD sdk d39b67d Remove more unused classes from engine.dart e35408d update REMOVE_TYPE_ANNOTATION assist error associations d36f5ed Fix diagnostic documentation tests and add support for documenting parser codes 3d1712c Remove tests for unqualified identifiers from static_extension_getter_setter_conflicts_test 4f8f592 Remove adding prefixes for auto imports. be93b04 Introduce a better diagnostic message for unqualified references to static members within extensions de7ad46 Enable visibleForTesting on unnamed constructors 80040e5 Remove errors for raw types in `is` or `as` expressions. 2cc0c4f Update doc comments for `dart:js` dd3d654 Rewrite property resolution, fix reporting errors when compound assignment without a getter. 76e6325 Remove unused methods of AnalysisContext. fb2e6c6 [test] Remove non-kernel versions of service tests. 27918cd fix for prefer_inlined_adds a7e71c3 [test] Fixes run_appended_aot_snapshot_test in precompiled mode. 16c7ac9 move const method error reporting into parser 9113fb3 Move the remaining StaticWarningCode tests to their own files 1b67cc7 Suggest completions for extensions in parts 88e9499 [vm/compiler] Check def/use relation for PushArguments in environment. 488a8ae [vm/compiler] Don't propagate non-constants as constants. 46b5839 [Runtime] Adds appended blob runtime mode. 11c5c34 [infra] Check whether sdk and sdk_nnbd are in sync on presubmit. 4d5e15a Fix broken static_extension_getter_setter_test. cbdbb46 [vm] Repair fingerprinting of recognized methods. 1e9a065 [vm/fuzzer] Restrict depth of ... operator a0fd607 [vm/fuzzer] add missing space f3b2d77 Migration: rework assignment handling. 1bbee61 Migration: handle binary expressions whose LHS has type `dynamic`. 75fd88c Migration: handle dynamic function expression invocations. eeb1716 Migration: don't forget to visit arguments to dynamic invocations. 3cccd7f Migration: handle `??=` assignments. 13ba681 [vm/compiler] DIV/MOD magic for ARM64 03b1951 Revert "[vm, snapshot] Use data image pages for kFull snapshots." 5303538 [vm/fuzzer] re-enable control flow collections 9a9c0f3 [test] Update status for some mirrors tests under reload stress testing. 6e01ad4 Fix for codeOffset/codeLength for enum constants. 3f7805a Make the NNBD command-line options less, uh, half-baked. 2305d9f [vm/compiler] Better be ready for OSR in field init 79137ed Migration: create flow anaylsis before visiting parameters. 1100aab Migration: handle `this` or `super` in generic classes. d93d70a [dart2js] Add test for issue flutter#38005. 64360e9 [vm/bytecode] Do not expect _ClosureCall in interpreted async stack traces. f3911df Update included element kinds to include extensions 81dc269 Status file cleanup. e82d111 Remove _CheckBuildStatus on commit 90866d3 Remove unused import 30ea777 fix parsing of "?.." cascade operator 13fc090 Fix language_2/map_literal3_test/03. 7ffb9de Update the version in the extension methods version hint 557f912 Add canned_checks.CheckPatchFormatted to presubmit 004d49b Make a fork of sdk/lib for use by NNBD. ca7baa4 [vm/fuzzer] Add virtual methods 2b966a9 [vm/fuzzer] Fix reproduction output c11ca7d Check for CompileTimeErrorCode.CONST_WITH_TYPE_PARAMETERS in LinterContext.canBeConst(). 7bbfd53 [vm, reload] Remove _getUnusedChangesInLastReload. abb606e [release] Update checked in SDKs to 2.5.0 24857b7 fix for prefer_spread_collections fa099eb Look for both getter and setter in the hierarchy before looking for extension. 331271d Set id(s) for GenericFunctionType(s) in constructor initializers and default values. 300c333 [gardening] Always tag class_id register on arm64 in subtype test cache stub 6717bfe [vm/concurrency] Lock weak table to prepare for concurrent access. 8329968 fix for prefer_single_quotes 9357b48 [gardening] Use target::kWordSizeLog2 instead of kWordSizeLog2 on arm (fixes broken build) ef9d699 [vm/concurrency] Move all information except for the class pointers out of [ClassTable] into [SharedClassTable] 9a2e280 fix for avoid_relative_lib_imports 62f78a7 [nit] Fixes two typos: build flag and error string. 35a7f4b [release] Update CHANGELOG.md for 2.5.0 f16d6d5 [infra] Ignore newly detected flakes in try runs ccb6ba9 [cfe] Gather constraints from both possibilities for FutureOr f1f709e Migration: add support for metadata on library/import/export/part/part-of directives. 1daf84f [nnbd_migration] support spread elements 7413879 [analyzer] Add getter isNullAware to SpreadElement 78bf8f0 Fix language_2/deferred_load_library_wrong_args_test. 9fccb51 [vm/bytecode] Fix clobbering of exception handler types in bytecode reader. b4724c1 Fix language_2/regress_23408_test. 424ef36 [vm/fuzzer] Print steps to reproduce on divergence 76bc894 [vm/bytecode] Generate explicit DebugCheck for assignment to static field 95db62d [vm/io] Return data right away if it's ready. 601d893 Fix issue31596 tests 32848c3 Migration: Rework handling of assignments to FutureOr. 36648ac [nnbd_migration] Pass as casts to _handleAssignment 98837e6 [vm/bytecode] Workaround for incorrect type parameters in function types 4e7b77e Fix language_2/super_bound_closure_test a2c8b69 Status file cleanup 879cdef update scanner test 909e251 Fix regress_29025_test ecb9a11 Fix language_2/regress_22976_test ef2a21f [vm/bytecode] Use local variable information when compiling from bytecode 27f803d fix for convert_to_null_aware_operators 0851b9a Consider both getter and setter when deciding whether an extension reference is ambiguous. 4310d15 Fix language_2/type_promotion_more_specific_test/04 438c595 Fix language_2/regress_30339_test 9497b7b Delete language_2/regress_29405_test 6f38a73 Remove most of the task model. fbd21a0 Guard against null in exportedDeclarations. b461490 Migration: add support for indexing on a dynamic type. 9fd672b fix for prefer_expression_bodies c2e55a2 [vm/bytecode] Cleanup support for old bytecode format versions before v10 2e8d912 [developer] Allow async end events to have independent arguments. 09ce6d3 [vm, service] Remove _collectAllGarbage. bc24702 Add missing parens to static_extension_getter_setter_conflicts_test.dart e9dcb9f fix typo in factory; add mixin text for protected ab5e36b fix for prefer_int_literals 41c5b81 [cfe] Special error message for illegal override of a setter by a field e9c3eeb [infra] Add handling of signed SDK directories to promote.py ff0fda7 [cfe] Handle UnknownType using defaultDartType 129d4a6 simplify dartfix output 41bf744 update parser to report static constructor cb1efb8 update parser to allow "late var" in NNBD 99007f3 remove duplicate error generation in ClassBuilder fb73cb1 update parser to report MixinDeclaresConstructor error 355df2a split AstBuilder endClassConstructor out of endClassMethod event b6f6240 fix extension factory declaration in AST 618b56d fix conditional expression parsing with NNBD enabled fb446e5 [dartdevc] Properly emitting JS interop anonymous classes 4a4f7cb Migration: Handle uses of typedef types as expressions. 0b0c113 Migration: rework edge builder prefix handling. 028d97b Migration: handle references to already-migrated fields. cbe1352 Migration: add support for most compound assignments. daaa665 Migration: fix a corner case of post-dominator analysis. 23d2893 Remove asserts in TypeProviderImpl. 3d3bbc2 Remove 'strongMode' flag in StaticTypeAnalyzerTest. 7f8398e Changes to MockSdk to make it usable in linter. 116cfba Issue 38198. Fix for isMoreSpecific() extension. 9391e15 [ package:vm_service ] Added support for service protocol version 3.27. 13a69b5 [vm/bytecode] Replace ICData constant pool entries with DynamicCall cff9c58 Tighten call conventions in allowInterop c0f49b0 [vm/debugger] Pick the correct context async variable in bytecode frames. 68dede0 [ VM / Service ] Add getCpuProfileSamples RPC which returns a minimally processed sample buffer. 84db163 [vm] Remove dead --load_deferred_eagerly and dependent code tracking for library prefixes. 1d6ab52 [vm] Fix CoreSnapshotSize and StandaloneSnapshotSize to account for the image page size. fd7676e Fix language_2/config_import_corelib_test 5247036 fix for convert_to_if_element e1dc432 [vm/fuzzer] Update rerun output and parser script 2c219dd Replace AnalysisContextFactory with TestAnalysisContext. 67cdae3 Add import fix in missed case cf94c3a Additional tests verifying interaction between mixins, static extensions, and visiblity annotations (protected, visibleForTemplate, visibleForTesting). ffd50c0 Report EXTENSION_AS_EXPRESSION, set type fo dynamic. 254d077 [vm/fuzzer] Fix bug where FFI caused dart crash f5c0e2e [vm/concurrency] Ensure instance size in class table is either 0 or the correct size eb60f05 Support a fix to add a setter, both in extensions and elsewhere e227ffa Migration: improve handling of catch clauses. 40454f0 Fix language_2/f_bounded_quantification2_test 836f6de Fix language_2/f_bounded_quantification4_test 8ad0832 [vm/bytecode] Use static types of parameters when compiling from bytecode 1354ec9 fix for prefer_for_elements_to_map_fromIterable 152aa5a fix calls following null-assertion operator 4e4047a fix extension abstract method error a689f8d corelib_2/unsigned_shift_test fixes 6f4ceb8 [vm] Provide a couple more gdb helpers to print stack traces. d7c96f3 Migration: handle prefixed class references. 0d63ce1 Clean up MockSdkElements. 8022f88 Stop using TestTypeProvider in analyzer_plugin. e55a1e0 [vm/fuzzer] Add filter keywords to collect_data c6a6add [vm/fuzzer] Count re-runs d964c50 clear contents on TemplateElement#setInnerHtml before appending c8f3f13 [vm, snapshot] Use data image pages for kFull snapshots. add83ad Fix language_2/generic_no_such_method_dispatcher_test f5b5327 Fix language_2/compile_time_constant_static5_test e34d71f [nnbd_migration] Implement if/for in map/set da235a5 [nnbd_migration] Fix for elements for list literals 6ae9709 Create TestTypeProvider as TypeProviderImpl on MockSdkElements. 46d7064 Stop using resolutionMap in DDC. fb14bab [vm/fuzzer] disable control flow collections again 5d4940f Migration: remove a bogus comment 6043b53 Migration: add the ability to dump the graph after propagation. cdd2f85 Migration: handle upcasts from function type to Function or Object. 7e04e05 Migration: add an option to print just exception nodes rather than full stack traces. 28d16e1 Migration: implement substitution logic for generic function types. f48a5a9 Support create method fix for extensions 17c06c3 Unify to single TypeProviderImpl. 8c13ecf [cfe] Handle nested on-types 0a49dde Remove previewDart2 related code in some tests. 836039e Add MockSdkElements for creating dart:core and dart:async mocks. d8f1661 Support replacing similar names in extensions 4d0fa1e fix for slash_for_doc_comments dc204ec [CFE] Preserve file URIs of expressions in unevaluated constants. 0242f0c [kernel] FileUriExpression node 70a7cbf [vm] Support extensions in ffi transformation and tfa tree shaker 7152fd0 [cfe] Handle [] and []= on extensions deb2fcf [cfe] Handle extension operators 7ca157d [cfe] Thread nullability modifiers for some InterfaceTypes in outline ec7ec4e [gardening] Fix import to fix Flutter build f989605 Fix dartdoc typo in ffi 2246f0a Compute constant dependencies for constructor elements in canBeConst(). 981be87 Add configuration options and flags for controlling NNBD mode. 9ff104e Move StaticError and StaticErrorParser to a separate file. bad1816 Migration: add edge builder support for generic method invocations. 35f45f0 Do null-aware shorting for IndexExpression. 90aca0b Add test for incomparable on type resolution and fix expectations. f4229da [vm, bytecode] Produce compile-time errors instead of crashing when failing to resolve libraries etc. a64b06e [gardening] Migrate most files to be implicit-bool-conversion free 698d120 base processor migration; fix to add type annotations d9a9346 [vm/compiler] Fix truncating logic d2dc053 Corrections to "[vm] Fix ASAN build." 592914f Don't report HintCode.CAN_BE_NULL_AFTER_NULL_AWARE when NNBD. c219a76 Reland "[vm/ffi] Implement FFI callbacks on AOT for ELF and Asm snapshots (excl. blobs)." 6a8c988 Simplify the computeCompilerArguments(). 9a847a9 [ VM / Service ] Fix docs for @instance not including optional closureFunction and closureContext fields ff8b437 Move reporting INVALID_ASSIGNMENT for compound assignments into StaticTypeAnalyzer. cf5e9ca Additional tests and fixes for creating getters 6e3498c bump server SDK constraint lower bound 89dde05 Migration: fix handling of assignments involving FutureOr. ec48af6 Support fix to import a library defining an extention 4fbd758 [vm/bytecode] Optimize comparisons with null 16a4c0d Bump up oldest_supported_abi_version for abi bot c7bb9cf refactor to share common fix/assist processor code 5a45050 [observatory] Flatten the heap snapshot before loading. 75374b8 [vm] Fix ASAN build. 8ee3f31 [vm/gardening] clang tidy fixes 89ad636 Remove the old "preview Dart 2" flags from the test runner. aa34de3 Flow analysis: adjust _variableInfosEqual to do a shallow comparison. ea35690 Flow analysis: add unit tests of try/finally handling. b179ef3 Flow analysis: add unit tests of try/catch handling. e2a00dc Flow analysis: add unit tests of while statements edceedf [vm, reload] Allow any change to a class that hasn't yet been declaration loaded. 68ba13e With NNBD null-shorting is performed. a7723d5 [vm] Out-line handle allocation. 16be3a0 [vm/benchmark] Add *Bytes suffix to Isolate SendReceive benchmark ```
|
Did a dart license change? It looks like the license script needs to be rerun. |
Yes, fixed. |
|
thanks @jonahwilliams ! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 12, 2019
git@github.com:flutter/engine.git/compare/bbb1f124671b...bf91a8d git log bbb1f12..bf91a8d --no-merges --oneline 2019-09-12 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (flutter/engine#12238) 2019-09-12 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (flutter/engine#12237) 2019-09-12 aam@google.com Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (flutter/engine#12235) 2019-09-12 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (flutter/engine#12236) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
git@github.com:flutter/engine.git/compare/bbb1f124671b...bf91a8d git log bbb1f12..bf91a8d --no-merges --oneline 2019-09-12 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (flutter/engine#12238) 2019-09-12 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (flutter/engine#12237) 2019-09-12 aam@google.com Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (flutter/engine#12235) 2019-09-12 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (flutter/engine#12236) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes since last dart roll: