This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Implement Base32Decode #12253
Merged
Implement Base32Decode #12253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuqian
force-pushed
the
base32decode
branch
from
f3a6683 to
ad0daa8
Compare
fml/base32.cc
Outdated
| } | ||
| bits_length += 5; | ||
| bits = (bits << 5) | kDecodeMap[map_index]; | ||
| FML_DCHECK(bits_length < 16); |
There was a problem hiding this comment.
Please make this a release check or just return false from this method.
There was a problem hiding this comment.
I encapsulated a BitConverter class that's used for both encoding and decoding for better safety and readability. This bits_length < 16 condition is supposed to be checkable at compile time. Hopefully the encapsulated class makes it clearer.
fml/base32.cc
Outdated
| static constexpr int kDecodeMapSize = | ||
| sizeof(kDecodeMap) / sizeof(kDecodeMap[0]); | ||
|
|
||
| std::pair<bool, std::vector<char>> Base32Decode(const std::string& input) { |
There was a problem hiding this comment.
Can this be just a string as well? You can use std::stringstream instead of a vector below.
There was a problem hiding this comment.
Changed to string. I originally wrote vector because I'm a little worried about char '\0'. Now the unit tests have shown that string is Ok with it so I'm now happy to switch to string.
liyuqian
force-pushed
the
base32decode
branch
3 times, most recently
from
f539e82 to
f865248
Compare
For flutter/flutter#32170 This is to enable reading back SkSL persistent cache filenames and decode them as SkData.
liyuqian
force-pushed
the
base32decode
branch
from
f865248 to
a2d11af
Compare
chinmaygarde
approved these changes
Sep 13, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 16, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 16, 2019
git@github.com:flutter/engine.git/compare/2c4ed36c60ae...8a8610a git log 2c4ed36..8a8610a --no-merges --oneline 2019-09-16 liyuqian@google.com Implement Base32Decode (flutter/engine#12253) 2019-09-16 liyuqian@google.com Reland "Smooth out iOS irregular input events delivery (#11817)" (flutter/engine#12280) 2019-09-16 mouad.debbar@gmail.com Refactor and polish the 'felt' tool (flutter/engine#12258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
git@github.com:flutter/engine.git/compare/2c4ed36c60ae...8a8610a git log 2c4ed36..8a8610a --no-merges --oneline 2019-09-16 liyuqian@google.com Implement Base32Decode (flutter/engine#12253) 2019-09-16 liyuqian@google.com Reland "Smooth out iOS irregular input events delivery (flutter#11817)" (flutter/engine#12280) 2019-09-16 mouad.debbar@gmail.com Refactor and polish the 'felt' tool (flutter/engine#12258) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For flutter/flutter#32170
This is to enable reading back SkSL persistent cache filenames
and decode them as SkData.