This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] filter test targets; cache host.dart compilation #12445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
approved these changes
Sep 25, 2019
lib/web_ui/dev/test_runner.dart
Outdated
| await _runAllTests(); | ||
| } else { | ||
| await _buildTests(targets: targets); |
There was a problem hiding this comment.
Let's call them _buildAllTests and _buildTargetTests to keep the naming consistent?
There was a problem hiding this comment.
Actually, I'm being silly. _buildTests(targets: targets) works in both cases. The behavior of -t w.r.t. to empty list is the same as --build-filter.
Deduped.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 25, 2019
…er/engine#12445) (#41321) git@github.com:flutter/engine.git/compare/efb7bf434f2c...3360d86 git log efb7bf4..3360d86 --no-merges --oneline 2019-09-25 yjbanov@google.com [web] filter test targets; cache host.dart compilation (flutter/engine#12445) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
…er/engine#12445) (flutter#41321) git@github.com:flutter/engine.git/compare/efb7bf434f2c...3360d86 git log efb7bf4..3360d86 --no-merges --oneline 2019-09-25 yjbanov@google.com [web] filter test targets; cache host.dart compilation (flutter/engine#12445) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings retest of a single test from minutes to seconds.
This is based on the new build_runner feature dart-lang/build#2415 by @jakemac53 (Thank you @jakemac53 !!!)