This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix typo on channel buffer debug output. #12960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Oct 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 8, 2019
git@github.com:flutter/engine.git/compare/3a445edda924...5b31822 git log 3a445ed..5b31822 --no-merges --oneline 2019-10-08 bkonyi@google.com Roll src/third_party/dart aece1c1e92..f4a72bfc64 (4 commits) 2019-10-08 30870216+gaaclarke@users.noreply.github.com Added an embedder example (flutter/engine#12808) 2019-10-08 sebastian.roth@gmail.com Fix typo on channel buffer debug output. (flutter/engine#12960) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/3a445edda924...5b31822 git log 3a445ed..5b31822 --no-merges --oneline 2019-10-08 bkonyi@google.com Roll src/third_party/dart aece1c1e92..f4a72bfc64 (4 commits) 2019-10-08 30870216+gaaclarke@users.noreply.github.com Added an embedder example (flutter/engine#12808) 2019-10-08 sebastian.roth@gmail.com Fix typo on channel buffer debug output. (flutter/engine#12960) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Overflow on channel: plugins.flutter.io/firebase_messaging. Messages on this channel are being discarded in FIFO fashion. The engine may not be running or you need to adjust the buffer size if of the channel.After:
Overflow on channel: plugins.flutter.io/firebase_messaging. Messages on this channel are being discarded in FIFO fashion. The engine may not be running or you need to adjust the buffer size of the channel.Also, @gaaclarke - I believe this is your TODO? :-)