This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Ensure we call into Engine from the UI taskrunner in Shell::EngineHasLivePorts() #13265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests for this are going to be covered by flutter/flutter#43189 which I am actively working on (I caught this bug working on that issue) |
chinmaygarde
approved these changes
Oct 21, 2019
gw280
force-pushed
the
gwright-shell-uithread
branch
from
e45d992 to
f572538
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2019
…ngineHasLivePorts (flutter/engine#13265)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 22, 2019
git@github.com:flutter/engine.git/compare/39e6901e6395...a064063 git log 39e6901..a064063 --no-merges --oneline 2019-10-22 a-siva@users.noreply.github.com Manual Roll of Dart from a61c775db8...e1c409792c (flutter/engine#13282) 2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4a152d340f06..f3f8ac37e468 (1 commits) (flutter/engine#13283) 2019-10-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from hALu4... to xGLLm... (flutter/engine#13284) 2019-10-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from _e7Up... to _PqfD... (flutter/engine#13285) 2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 81e8d3b29662..4a152d340f06 (2 commits) (flutter/engine#13281) 2019-10-22 vsm@google.com Enable/tweak web sdk source maps, take 2 (flutter/engine#13161) 2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 56f569d9bec2..81e8d3b29662 (7 commits) (flutter/engine#13277) 2019-10-22 matthew-carroll@users.noreply.github.com Forwards Activity result to FlutterFragment in FlutterFragmentActivity. (flutter/engine#13214) 2019-10-21 gw280@google.com Ensure we call into Engine from the UI taskrunner in Shell::EngineHasLivePorts (flutter/engine#13265) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/39e6901e6395...a064063 git log 39e6901..a064063 --no-merges --oneline 2019-10-22 a-siva@users.noreply.github.com Manual Roll of Dart from a61c775db8...e1c409792c (flutter/engine#13282) 2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4a152d340f06..f3f8ac37e468 (1 commits) (flutter/engine#13283) 2019-10-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from hALu4... to xGLLm... (flutter/engine#13284) 2019-10-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from _e7Up... to _PqfD... (flutter/engine#13285) 2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 81e8d3b29662..4a152d340f06 (2 commits) (flutter/engine#13281) 2019-10-22 vsm@google.com Enable/tweak web sdk source maps, take 2 (flutter/engine#13161) 2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia 56f569d9bec2..81e8d3b29662 (7 commits) (flutter/engine#13277) 2019-10-22 matthew-carroll@users.noreply.github.com Forwards Activity result to FlutterFragment in FlutterFragmentActivity. (flutter/engine#13214) 2019-10-21 gw280@google.com Ensure we call into Engine from the UI taskrunner in Shell::EngineHasLivePorts (flutter/engine#13265) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shell's methods need to be called from the platform taskrunner, and Engine methods need to be called from the UI taskrunner. Currently we violate this by calling directly into Engine::UIIsolateHasLivePorts() from a Shell method which is running on the platform taskrunner.