This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Changing test runner and platform to be browser independent #13869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
reviewed
Nov 18, 2019
yjbanov
approved these changes
Nov 18, 2019
added 6 commits
November 19, 2019 10:38
…elated maps and utilities
nturgut
force-pushed
the
firefox_tests_part2
branch
from
be37a88 to
f94822d
Compare
tvolkert
added a commit
to tvolkert/flutter
that referenced
this pull request
Nov 20, 2019
flutter/engine@c812a62...2d35b4e Expose the platform view mutator stack to custom compositors. (flutter/engine#13731) Roll fuchsia/sdk/core/linux-amd64 from T9BAw... to 7mmHP... (flutter/engine#13924) Changing test runner and platform to be browser independent (flutter/engine#13869) Roll Skia to e678b79c489d (2 commits) (flutter/engine#13923)
tvolkert
added a commit
to flutter/flutter
that referenced
this pull request
Nov 20, 2019
flutter/engine@c812a62...2d35b4e Expose the platform view mutator stack to custom compositors. (flutter/engine#13731) Roll fuchsia/sdk/core/linux-amd64 from T9BAw... to 7mmHP... (flutter/engine#13924) Changing test runner and platform to be browser independent (flutter/engine#13869) Roll Skia to e678b79c489d (2 commits) (flutter/engine#13923)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made a lot of changes in both files to make sure that nothing is hardcoded as chrome.
Also disable screenshot tests if the test is any browser other than chrome.
Note that the tests won't run on Firefox yet. As a last change I'll change dart_test.yaml
Related to issue: flutter/flutter#44959